(MOT-3868) fix(harness): publish typed request schema for harness::react - #405
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
skill-check — worker0 verified, 32 skipped (no docs/).
Four for four. Nicely done. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe harness::react function registration now uses a typed ReactEvent(pub Value) wrapper implementing JsonSchema instead of a generic Value, with corresponding catalog wiring, golden schema file, and registration-order test updates. ChangesReactEvent typed schema integration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
ReactEventwire-schema wrapper forharness::reactwhile preserving the losslessserde_json::Valueruntime payload (same pattern asNotifyAgentEventinharness::notify_agent).harness::reactwith that typed request shape so release interface collection no longer publishesAnyValuefor its request schema.harness::reactto the harness schema catalog and commit the new golden snapshot.Root Cause
The harness release publish gate collected
worker-interface.jsonsuccessfully, then failed becauseharness::react.request_schemawas the permissiveAnyValueschema. The handler was registered with a rawserde_json::Valueevent payload even though the registry publish gate requires typed function request/response schemas.Validation
UPDATE_GOLDENS=1 cargo test --manifest-path harness/Cargo.toml --test schemascargo test --manifest-path harness/Cargo.tomlcargo clippy --manifest-path harness/Cargo.toml --all-targets -- -D warningsgit diff --checkFixes MOT-3868
Summary by CodeRabbit
New Features
Bug Fixes