Skip to content

(MOT-3868) fix(harness): publish typed request schema for harness::react - #404

Closed
ytallo wants to merge 1 commit into
mainfrom
codex/fix-harness-react-schema
Closed

(MOT-3868) fix(harness): publish typed request schema for harness::react#404
ytallo wants to merge 1 commit into
mainfrom
codex/fix-harness-react-schema

Conversation

@ytallo

@ytallo ytallo commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a typed ReactEvent wire-schema wrapper for harness::react while preserving the lossless serde_json::Value runtime payload (same pattern as NotifyAgentEvent in harness::notify_agent).
  • Register harness::react with that typed request shape so release interface collection no longer publishes AnyValue for its request schema.
  • Add harness::react to the harness schema catalog and commit the new golden snapshot.

Root Cause

The harness release publish gate collected worker-interface.json successfully, then failed because harness::react.request_schema was the permissive AnyValue schema. The handler was registered with a raw serde_json::Value event payload even though the registry publish gate requires typed function request/response schemas.

Validation

  • UPDATE_GOLDENS=1 cargo test --manifest-path harness/Cargo.toml --test schemas
  • cargo test --manifest-path harness/Cargo.toml
  • cargo clippy --manifest-path harness/Cargo.toml --all-targets -- -D warnings
  • git diff --check

Fixes MOT-3868

@vercel

vercel Bot commented Jul 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
workers Ready Ready Preview, Comment Jul 3, 2026 10:51pm
workers-tech-spec Building Building Preview Jul 3, 2026 10:51pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 751a6767-f95d-4a6b-833b-f54f9ffa7621

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-harness-react-schema

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

skill-check — worker

0 verified, 32 skipped (no docs/).

Layer Result
structure
vale
ai
render

Four for four. Nicely done.

@ytallo ytallo closed this Jul 3, 2026
@ytallo
ytallo deleted the codex/fix-harness-react-schema branch July 3, 2026 22:54
@ytallo ytallo changed the title [codex] fix harness react schema publish (MOT-3868) fix(harness): publish typed request schema for harness::react Jul 3, 2026
@ytallo

ytallo commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #405 (branch renamed; GitHub auto-closed this PR on rename).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant