chore(llm-router, provider-anthropic): conform to the worker SOPs - #258
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
More reviews will be available in 15 minutes and 42 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (12)
📝 WalkthroughWalkthroughThis PR introduces two new worker modules, ChangesWorker Module Integration: llm-router and provider-anthropic
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
skill-check — worker0 verified, 18 skipped (no docs/).
Four for four. Nicely done. |
…binary-worker SOPs - main.rs: clap CLI (--config/--url/--manifest), tracing init, WorkerMetadata identity, and shutdown_async on exit; --url honours III_WS_URL as a fallback. A --config file carrying real keys now warns instead of being silently ignored (operator config lives in the engine's llm-router configuration entry). - config.yaml: committed stubs documenting where configuration lives. - Release wiring: both workers added to create-tag.yml options and release.yml tag patterns. Versions pre-bumped (llm-router 0.2.0, provider-anthropic 0.3.0) above the retired predecessors' tags so the first Create Tag run cannot collide. - README: Modules table rows for both workers; per-worker READMEs document the CLI flags. - iii-permissions.yaml: deny provider::* — direct provider calls bypass the router's accounting; the router invokes them worker-to-worker.
84b07a1 to
033df75
Compare
Brings
llm-routerandprovider-anthropicinto line withdocs/sops/new-worker.mdanddocs/sops/binary-worker.md. Both were already shipping but skipped several SOP requirements.Gaps closed
main.rsfiles are rewritten to the binary-worker scaffold (mirroringsession-manager, the SOP's reference worker on the same SDK0.19.2): clap with--config/--url/--manifest,tracing_subscriberinit, aWorkerMetadataidentity line (they previously registered anonymously), andiii.shutdown_async().awaiton exit.--urlkeeps honouringIII_WS_URLas a fallback.config.yaml. Both workers deliberately keep operator config in the engine'sllm-routerconfiguration entry, so each ships a committed stub documenting that. The engine passes--config <path>whenever an operator sets a config block, so the binary now warns about ignored keys instead of dropping all argv silently.create-tag.ymloptions andrelease.ymltag patterns.llm-router/v0.1.1–v0.1.2,provider-anthropic/v0.1.0–v0.2.1). With manifests at0.1.0the first Create Tag run would push an already-existing tag, which fails silently. Versions are pre-bumped above those lineages — llm-router → 0.2.0, provider-anthropic → 0.3.0 — with a comment in eachCargo.toml.iii-permissions.yaml(the file the harness actually loads) had no matching rule — they fell toneeds_approval. Added'!provider::*'.Test plan
cargo fmt --check,cargo clippy --all-targets --all-features -- -D warnings,cargo test --all-featurespass in both workers (llm-router 56 tests, provider-anthropic 76; includes new unit tests for the config-key detection).--manifest | jqemits valid manifests at the new versions;--helpshows the CLI contract.--configfile and stays silent for the committed stub.Summary by CodeRabbit
New Features
llm-routerandprovider-anthropicworker modules.--url,--config,--manifest) to both modules.Documentation
Chores