WIP: Sync changes from twitter/twemproxy #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typo circunous -> circonus
fix a memory leak bug for mset command
Support for these was introduced in @4175419288ef66d95e082cfa2124e77fe6d4fe6d.
Update redis docs for PING and QUIT
Added Greta to the list of companys
Update the sensu-metrics link
Update README.md
Fix typo in notes/memcache.md
fix typo in README.md
It seems like field->perm might be uninitialized memory depending on how it is allocated. I ran into an issue where different sockets had different file permissions, and some of those sockets weren't readable by the user which created it. This behavior probably started in https://github.com/twitter/twemproxy/pull/311/files
Adding issue and pull request templates to comply with twitter OSS best practices.
allow spop can parameters
Fix indented bulleted list and add monospaced formatting to command flags within paragraphs
Add Docker support
Fix README typo
This detects some inconsistent uses of indentation and inconsistent space after casts, but has a lot more false positives. https://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting may be of use for saving time for contributors reformatting new patches
Plugins for editors/IDEs exist that can enforce some of these rules
Fix processing of redis multibulk (nested array) responses (from eval, new commands, etc)
Revert the addition of blocking commands - making them a compilation option is probably a poor way to distribute it. Support `COMMAND` (used by redis-cli) and a placeholder no-argument command forwarded to a random server.
…mmands-followup Followup for new redis commands and multibulk support
The size of the difference between two pointers depends on the platform (e.g. 64bit vs 32bit pointers), so cast it to an integer - it should fit in that range anyway.
Fail GitHub actions builds on new compiler warnings, warn about incorrect log format strings
This uses commands.json from redis's documentation to determine which category a given redis command falls into. This will be useful to ensure that twemproxy stays up to date with new redis commands.
…gcounts [skip ci] Add script to extract redis key/arg count ranges
The recent patches add support for a placeholder key, which is actually a constant string in memory. The logging helper method should not be mutating the data it's logging. Specify the length of the string to log instead of introducing a null byte.
Fix a crash seen when logging redis `COMMAND` in recent patches
fix list indentation in README
https://github.com/linsomniac/python-memcached/ 1.5.8 had the delete_multi signature fixed in 2016. Anyone who had installed an outdated version should have seen this recommendation already or worked around it differently. There are a large number of other languages that have their own memcache clients with different bugs, don't continue linking to the workaround for an outdated python-memcached client version Closes twitter#475
[skip ci] Remove reference to outdated python-memcached version
Improve formatting of README file
Update tests
Add const value qualifiers for C functions where applicable
…twitter-v2 Conflicts: .dockerignore .github/workflows/main.yml .travis.yml ChangeLog README.md ci/build-nutcracker.sh src/Makefile.am src/hashkit/nc_hashkit.h src/nc_connection.c src/nc_mbuf.c src/nc_message.c src/nc_message.h src/nc_request.c src/nc_server.c src/proto/nc_memcache.c src/proto/nc_proto.h src/proto/nc_redis.c src/test_all.c tests/test_redis/test_basic.py travis.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.