-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker support #524
Add Docker support #524
Conversation
Bump. |
LGTM, can someone please merge this and add an autobuild for docker hub? |
@manjuraj : ping (since you're the main commiter) |
Dynomite has Dockerfile. Maybe we should consider that too. https://github.com/Netflix/dynomite/blob/dev/docker/Dockerfile Also, we should use Docker multi-stage build to further reduce footprint. |
Any update on this? |
@manjuraj: Anything else needed here? I've done a quick search, and there are lots of rogue twemproxy public Docker images:
Having an official one would be better, IMO. |
Done. Thank you @pataquets! |
@manjuraj You're welcome :) |
@manjuraj Fancy to set up an Automated Build on Docker Hub? Or any other similar 'source-built' Docker public image as a snapshot and deployable artifact. |
Add Dockerfile to enable image building.
Using the official GCC image, latest tag. More info at https://hub.docker.com/_/gcc/
Just adding files, setting working dir and running make instructions.
Build:
Run:
FYI, there's a still quicker to test, already built image on my Docker Hub. Test it by running:
Using
--rm
instead of-d
makes the container not go background and it to be deleted after stop. Should stop byCTRL+C
'ing it.In order for the Docker container to connect to external memcached or Redis instances, either them should be contactable as external IPs or hosts or be linked to other previously run Docker containers via Docker's
--link
option.Here it is an example Docker Compose file I'm using (I can submit it with the PR also if you find it useful):
Notice that it is tuned for two Redis instances (yml file not included, mount yours)
Optional improvement to come (maybe in another issue):