Bugfix/fix remove index add index 125 #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagliala
force-pushed
the
bugfix/fix-remove-index-add-index-125
branch
7 times, most recently
from
c3128ad to
f362550
Compare
|
We have discussed this modular approach some while ago. Since we have a lot of issues with those method signatures, I've tried to separate modules. I still don't like it (naming and default behavior, mostly), but this solves the issue and we have removed all the inline checks of ruby versions and rails versions that were causing headaches |
gridanjbf
reviewed
Dec 1, 2021
amicojeko
reviewed
Dec 1, 2021
tagliala
commented
Dec 1, 2021
tagliala
force-pushed
the
bugfix/fix-remove-index-add-index-125
branch
from
f362550 to
79eed4e
Compare
gridanjbf
reviewed
Dec 1, 2021
tagliala
force-pushed
the
bugfix/fix-remove-index-add-index-125
branch
2 times, most recently
from
1030c27 to
c3e1317
Compare
The signature of `add_index` and `remove_index` is different among Rails 6.1 and older Rails versions. The previous implementation with conditional checking did not cover all the cases This approach conditionally requires implementations basing on AR version Fix #125
tagliala
force-pushed
the
bugfix/fix-remove-index-add-index-125
branch
from
c3e1317 to
fe0d525
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.