Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Frontend upgrade #354

Merged
merged 6 commits into from
Dec 12, 2023
Merged

chore: Frontend upgrade #354

merged 6 commits into from
Dec 12, 2023

Conversation

mgax
Copy link
Contributor

@mgax mgax commented Dec 4, 2023 •
edited
Loading

  • Fix obvious warnings from yarn install and yarn build.
  • Remove the eslint-plugin-springload dependency – a linter plugin that is unmaintained.
  • Upgrade dependencies with minimal changes to package.json constraints.
  • Bump NodeJS to v20.

Running yarn audit shows no issues:

yarn audit v1.22.21
0 vulnerabilities found - Packages audited: 598
✨ Done in 0.66s.

@mgax
Fix warnings from yarn install
68e8522
@mgax
Update browserlist
7f14269 
This is the result of running `npx browserslist@latest --update-db`.
@mgax
Upgrade dependencies
4665140 
Result of running `yarn upgrade`
@mgax
Upgrade html-webpack-plugin
7c19305 
Fixes build warning:

```
(node:40591) [DEP_WEBPACK_COMPILATION_ASSETS] DeprecationWarning: Compilation.assets will be frozen in future, all modifications are deprecated.
BREAKING CHANGE: No more changes should happen to Compilation.assets after sealing the Compilation.
	Do changes to assets earlier, e. g. in Compilation.hooks.processAssets.
	Make sure to select an appropriate stage from Compilation.PROCESS_ASSETS_STAGE_*.
    at /Users/mgax/tbx/ietf/wagtail_website/node_modules/html-webpack-plugin/index.js:286:49
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
```
@mgax
Switch to Node 18
a1c5d87
@mgax
Switch to Node 20
3efec19
@mgax mgax mentioned this pull request Dec 4, 2023
Merged
20 tasks
@mgax mgax marked this pull request as ready for review December 12, 2023 14:17
@mgax
Copy link
Contributor Author

mgax commented Dec 12, 2023

I had left this PR as draft for a few days, hoping to come back to the linting setup (where I've removed eslint-plugin-springload without adding anything in its place). But I suspect it's useful anyway – better to have an up-to-date toolchain with less linting than hold it off.
I've marked it as "ready" now because I'd like to base the work for #253 off of this upgrade. @kesara might you have a look? Thanks!

@kesara kesara merged commit 0694e7f into ietf-tools:main Dec 12, 2023
5 checks passed
@mgax mgax deleted the frontend-upgrade branch December 14, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesara kesara kesara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgax @kesara