Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Upgrade backend (Python, Django, Wagtail) #350

Merged
merged 13 commits into from
Dec 5, 2023

Conversation

mgax
Copy link
Contributor

@mgax mgax commented Nov 28, 2023

⚠️ After deploying this change, the following command should be run on the production instance, to copy daily search hits data from the wagtailsearch.Query model to wagtailsearchpromotions.Query:

./manage.py copy_daily_hits_from_wagtailsearch

Upgrade the backend across the board:

  • Fix deprecation warnings (moved to chore: Fix warnings #352)
    • Move bibliography app config to apps.py
    • Replace url with re_path
    • Replace usage of deprecated assertEquals
    • Treat warnings as testing errors
  • Switch to pip-tools version pinning
  • Upgrade to Django 4.0
    • Add workaround for missing source maps (needs further investigation) Fix source map output in webpack
  • Drop django-compressor and django-libsass (they don't seem to do anything useful; the frontend build already compiles *.scss files)
  • Upgrade to Wagtail 4.2
  • Upgrade to Django 4.1
  • Upgrade to Python 3.11
  • Write test for a simple search query (because search broke when upgrading to Wagtail 5.0)
  • Upgrade to Wagtail 5.0
  • Django 4.2
  • Wagtail 5.1 (fixes Update to Wagtail 5.1 #322)
  • Wagtail 5.2
  • Python 3.12
  • Other Python dependencies
  • Frontend upgrades (moved to chore: Frontend upgrade #354)
    • Check for unmaintained frontend dependencies
    • Node 18
    • Node 20

@mgax mgax force-pushed the upgrade branch 2 times, most recently from 72a96f6 to 6d0b557 Compare November 29, 2023 13:04
@mgax mgax changed the title refactor: Upgrade Python, Django and Wagtail refactor: Upgrade Python, Django, Wagtail and frontend dependencies Nov 29, 2023
@mgax mgax changed the title refactor: Upgrade Python, Django, Wagtail and frontend dependencies refactor: Upgrade backend (Python, Django, Wagtail) Dec 5, 2023
@mgax mgax marked this pull request as ready for review December 5, 2023 13:18
options.mode !== 'production' ? 'inline-source-map' : undefined,
options.mode !== 'production' ? 'eval-source-map' : undefined,
Copy link
Contributor Author

@mgax mgax Dec 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Django 4.0, ManifestStaticFilesStorage checks for missing files, and the build output with inline-source-map was failing because of a link to a missing bootstrap.esm.js.map. Changing the devtool option to eval-source-map, which is their Recommended choice for development builds with high quality SourceMaps, fixed the issue

@kesara kesara changed the title refactor: Upgrade backend (Python, Django, Wagtail) refactor!: Upgrade backend (Python, Django, Wagtail) Dec 5, 2023
@kesara kesara changed the title refactor!: Upgrade backend (Python, Django, Wagtail) feat!: Upgrade backend (Python, Django, Wagtail) Dec 5, 2023
@kesara kesara merged commit baca04e into ietf-tools:main Dec 5, 2023
5 checks passed
@mgax mgax deleted the upgrade branch December 6, 2023 09:15
@mgax mgax mentioned this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants