Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: total ids, pre-pubreq counts and pages left to ballot on on the AD dashboard #7813

Merged
merged 30 commits into from
Sep 5, 2024

Conversation

rjsparks
Copy link
Member

@rjsparks rjsparks commented Aug 9, 2024

No description provided.

@evyncke
Copy link
Contributor

evyncke commented Aug 14, 2024

Suggest to rename "pre pubreq" into something else because it looks like "pub req" (both are 2-works column title).

Is it "WG adopted document" ? or "WG I-D passed the WGLC" ? It is a little unclear.

@rjsparks
Copy link
Member Author

It's documents that have wg or ad state that indicate they are a draft that's on its way to stream processing. The details can be seen here (scroll the window) - look in particular at L496:

# https://github.com/ietf-tools/datatracker/issues/4577
docs_via_group_ad = Document.objects.exclude(
group__acronym="none"
).filter(
group__role__name="ad",
group__role__person=ad
).filter(
states__type="draft-stream-ietf",
states__slug__in=["wg-doc","wg-lc","waiting-for-implementation","chair-w","writeupw"]
)
doc_for_ad = Document.objects.filter(ad=ad)
ad.pre_pubreq = (docs_via_group_ad | doc_for_ad).filter(
type="draft"
).filter(
states__type="draft",
states__slug="active"
).filter(
states__type="draft-iesg",
states__slug="idexists"
).distinct().count()

See also the discussion at #4577

I'm happy to take a suggestion for a different name, but this one is the one that was asked for.

Copy link
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. We ought to move the inline javascript out of the template, but I'm not going to insist we do it here and now.

<script>
const data = JSON.parse(document.getElementById("data").textContent);
function highchartsConfigFactory({ element, ymax, series }){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ought to be moved to an external script

@rjsparks rjsparks merged commit cb25831 into main Sep 5, 2024
7 checks passed
@jennifer-richards jennifer-richards deleted the feat/ad-dash branch September 7, 2024 21:31
@jennifer-richards jennifer-richards restored the feat/ad-dash branch September 7, 2024 21:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants