feat: pages left to ballot on #7516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/ad-dash #7516 +/- ##
===============================================
Coverage ? 88.84%
===============================================
Files ? 295
Lines ? 41320
Branches ? 0
===============================================
Hits ? 36709
Misses ? 4611
Partials ? 0 ☔ View full report in Codecov by Sentry. |
holloway
commented
Jun 17, 2024
ietf/iesg/tests.py
Outdated
| logged_in_request = self.client.get(url) | ||
| telechats = logged_in_request.context["telechats"] | ||
| self.assertGreater(len(telechats), 0, "Expected multiple telechats but received %d" % (len(telechats))) | ||
| self.assertEqual(telechats[0]["ad_pages_left_to_ballot_on"], 383, "Expected a specific number of pages left to ballot on for this AD '%s'" % (username)) |
There was a problem hiding this comment.
The returned value telechats[0]["ad_pages_left_to_ballot_on"] varies on every test run due to (I'm guessing) race conditions in running tests. I tried moving lines 503-510 to the setUp but this didn't make a reproducible value. Thoughts anyone?
rjsparks
reviewed
Jun 17, 2024
ietf/iesg/tests.py
Outdated
| @@ -167,7 +166,7 @@ def setUp(self): | |||
| "conflrev": Document.objects.get(name="conflict-review-imaginary-irtf-submission"), | |||
| "statchg": Document.objects.get(name="status-change-imaginary-mid-review"), | |||
| "charter": Document.objects.filter(type="charter")[0], | |||
| } | |||
| } | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a 'pages left to ballot on' count for ADs for #6620