fix: check correct state machine when clearing status change ballots #7684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennifer-richards
previously approved these changes
Jul 13, 2024
jennifer-richards
requested changes
Jul 15, 2024
ietf/doc/views_ballot.py
Outdated
| @@ -403,7 +403,7 @@ def clear_ballot(request, name, ballot_type_slug): | |||
| by = request.user.person | |||
| if close_ballot(doc, by, ballot_type_slug): | |||
| create_ballot_if_not_open(request, doc, by, ballot_type_slug) | |||
| if doc.get_state('draft-iesg').slug == 'defer': | |||
| if doc.get_state("statchg").slug == "defer": | |||
There was a problem hiding this comment.
This shoul have a guard against doc.get_state() returning None. (I think this is the cause of the failing test)
There was a problem hiding this comment.
hmm - that just exposes another subtle bug - the check should be against the ballot_type_slug, and if there is no state, the view had best do nothing (404 would be right I think).
jennifer-richards
approved these changes
Jul 15, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7684 +/- ##
==========================================
- Coverage 88.98% 88.79% -0.20%
==========================================
Files 291 296 +5
Lines 40717 41318 +601
==========================================
+ Hits 36233 36687 +454
- Misses 4484 4631 +147 ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7335