Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempts to clear a status change ballots crash #7335

Closed
rjsparks opened this issue Apr 17, 2024 · 1 comment · Fixed by #7684
Closed

Attempts to clear a status change ballots crash #7335

rjsparks opened this issue Apr 17, 2024 · 1 comment · Fixed by #7684
Labels
accepted bug Something isn't working component: doc/ component: iesg/ major

Comments

@rjsparks
Copy link
Member 

AttributeError at /doc/status-change-mpls-rfc7506-to-historic/edit/clearballot/statchg/

'NoneType' object has no attribute 'slug'

Exception Location: | .../12.10.0/ietf/doc/views_ballot.py, line 405, in clear_ballot

cc: @cindymorgan
rjsparks added a commit to rjsparks/datatracker that referenced this issue Jul 12, 2024
@rjsparks
fix: check correct state machine when clearing status change ballots
f47d30c 
Fixes ietf-tools#7335
@rjsparks rjsparks mentioned this issue Jul 12, 2024
Merged
rjsparks added a commit that referenced this issue Jul 15, 2024
@rjsparks
fix: check correct state machine when clearing status change ballots (#…
17e0f57 
…7684)

* fix: check correct state machine when clearing status change ballots

Fixes #7335

* fix: Improve ballot clearing tests

* fix: look at the right state machines for defer state for a ballot

* fix: also do the right thing with conflrev defers
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted bug Something isn't working component: doc/ component: iesg/ major
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: check correct state machine when clearing status change ballots rjsparks/datatracker
2 participants
@rjsparks and others