fix: Expand and enforce Cancel Interim Meeting Request comments length to 512 #7069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pselkirk
commented
Feb 16, 2024
Comment on lines
+1
to
+18
| # Copyright The IETF Trust 2024, All Rights Reserved | ||
|
|
||
| from django.db import migrations, models | ||
|
|
||
|
|
||
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ("meeting", "0004_session_chat_room"), | ||
| ] | ||
|
|
||
| operations = [ | ||
| migrations.AlterField( | ||
| model_name="session", | ||
| name="agenda_note", | ||
| field=models.CharField(blank=True, max_length=512), | ||
| ), | ||
| ] |
There was a problem hiding this comment.
Note: #7003 also has a 0005 migration. One of these will have to be updated to 0006, depending on merge order.
pselkirk
commented
Feb 16, 2024
| {{ meeting.session_set.0.agenda_note }} | ||
| {{ meeting.session_set.first.agenda_note }} |
There was a problem hiding this comment.
Note: I'm deeply uneasy about this change, since I have to assume it worked before, but in my test environment, generated email had the line:
** No value found for 'meeting.session_set.0.agenda_note' **'
There was a problem hiding this comment.
Why assume it worked before? There's no test that looks to see if the note actually made it into the email i think.
Please add one.
I verified that the cancellation that led to this issue had a agenda_note added, but the email that went out did not contain it.
rjsparks
approved these changes
Feb 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6998