-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Distinguish failed from not-applied checkers #6220
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6220 +/- ##
==========================================
- Coverage 88.68% 88.68% -0.01%
==========================================
Files 290 290
Lines 40300 40306 +6
==========================================
+ Hits 35742 35747 +5
- Misses 4558 4559 +1
|
This feels like we're missing some tests. |
@jennifer-richards : please merge main in again |
# Conflicts: # ietf/submit/views.py
I agree. The existing tests of |
Fixes #4346
With this change, passing checks are unchanged, still "Your Internet-Draft has been verified to pass the submission checks."
and the wording for a failed test is now "Your Internet-Draft failed at least one submission check."
If no checks were applied, it says so, "No submission checks were applied to your Internet-Draft." The visual style is still
alert-warning
because this is not a healthy situation for a submission.This also refactors and reuses the
latest_checks()
method which should give better results if checks are applied multiple times (though afaik this does not happen often if at all).