Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission status display is sometimes misleading about checker results #4346

Closed
1 task done
jennifer-richards opened this issue Aug 19, 2022 · 1 comment · Fixed by #6220
Closed
1 task done

Submission status display is sometimes misleading about checker results #4346

jennifer-richards opened this issue Aug 19, 2022 · 1 comment · Fixed by #6220
Labels

Comments

@jennifer-richards
Copy link
Member

Describe the issue

The submission status page shows any passed/failed checker results (i.e., SubmissionCheck instances) for the submission. If there are no results or if all the instances are passing results, this is shown as a green box with the statement Your draft has been verified to pass the submission checks. If any are not passing, the box is red and the statement indicates that a check failed.

If there are no check results, this is still shown with the message indicating that the draft has been verified to pass the submission checks. This is misleading. It would be better to indicate that the validations have not been run.

Code of Conduct

@jennifer-richards
Copy link
Member Author

Note that on the dev branch for asynchronous submission, the checker results are suppressed for drafts in the "validating" state. This avoids the worst of the effect, but if such a draft is canceled before the checkers are complete, the misleading impression becomes visible.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants