Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add totals to nominee feedback page #5977

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Conversation

pselkirk
Copy link
Collaborator

Fixes #4727

@richsalz
Copy link
Collaborator

FWIW, this is a bit cleaner than #5406, but that was held up for lack of a test.

Also remember to wrap the totals in a <tr> tag.
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #5977 (ad71d61) into main (09f3477) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5977      +/-   ##
==========================================
- Coverage   88.67%   88.63%   -0.05%     
==========================================
  Files         288      288              
  Lines       40001    40014      +13     
==========================================
- Hits        35471    35466       -5     
- Misses       4530     4548      +18     
Impacted Files Coverage Δ
ietf/doc/utils.py 87.15% <100.00%> (+0.01%) ⬆️
ietf/nomcom/templatetags/nomcom_tags.py 70.83% <100.00%> (+3.64%) ⬆️
ietf/submit/forms.py 79.02% <100.00%> (+0.03%) ⬆️

... and 3 files with indirect coverage changes

@rjsparks rjsparks merged commit 3f228c7 into ietf-tools:main Jul 18, 2023
8 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "totals" to "view feedback" page
3 participants