fix: Add column totals to feedback (#4727) #5406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Better to test it with something in nomcom/tests.py |
larseggert
reviewed
Mar 27, 2023
rjsparks
requested changes
Mar 27, 2023
|
This didn't survive the automated change of branch target - I can work to straighten it out, or, if your local branch rebases easily, perhaps submit this again? (with apologies for the hassle). |
|
I'll figure something out; you have enough to do. |
|
Fixed the rebase issue, not the URL mapping yet. Sorry for the noise. |
rjsparks
reviewed
Apr 14, 2023
|
I think URL mapping was about a different PR? |
richsalz
commented
Apr 17, 2023
larseggert
reviewed
Apr 19, 2023
richsalz
commented
Apr 19, 2023
| <tfoot> | ||
| <td></td> | ||
| <td></td> | ||
| <th>Totals</h></th> |
There was a problem hiding this comment.
Do you think col is right? I didn't so I left it out
Create a new aggregate parameter that holds the totals and pass that into the HTML file as a parameter for display.
The fieldname is a variable, so we add a filter, `lookup` to do a dynamic dictionary lookup.
Add scope to `th`, per Lars. Co-authored-by: Lars Eggert <[email protected]>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.1 to 3.1.2. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3.1.1...v3.1.2) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Replaced by #5977 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new aggregate parameter that holds the totals and pass that into the HTML file as a parameter for display.
Not easy to test given #4627.