Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove temporary pin on pydantic #5911

Merged
merged 2 commits into from
Jul 5, 2023
Merged

chore: Remove temporary pin on pydantic #5911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a1a42b
chore: Remove temporary pin on pydantic
jennifer-richards Jul 4, 2023
fce2fb3
test: Guarantee ordering of sessions in test
jennifer-richards Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ietf/secr/sreq/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ def test_edit(self):
self.assertRedirects(r, redirect_url)

# Check whether updates were stored in the database
sessions = Session.objects.filter(meeting=meeting, group=mars)
sessions = Session.objects.filter(meeting=meeting, group=mars).order_by("id") # order to match edit() view
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case anyone looks back and notices this PR does more than remove the pin - this test happened to show instability while testing removal of the pin. We accepted taking the fix as part of this PR intentionally.

self.assertEqual(len(sessions), 2)
session = sessions[0]

Expand Down
1 change: 0 additions & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,4 +72,3 @@ Unidecode>=1.3.4
weasyprint>=59
xml2rfc>=3.12.4
xym>=0.6,<1.0
pydantic<2 # Temporary pin until inflect can catch up.