chore: Remove temporary pin on pydantic #5911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix an intermittent test failure.
Codecov Report
@@ Coverage Diff @@
## main #5911 +/- ##
==========================================
- Coverage 88.67% 88.65% -0.02%
==========================================
Files 288 288
Lines 39999 39999
==========================================
- Hits 35468 35461 -7
- Misses 4531 4538 +7 |
rjsparks
reviewed
Jul 5, 2023
| @@ -146,7 +146,7 @@ def test_edit(self): | |||
| self.assertRedirects(r, redirect_url) | |||
|
|
|||
| # Check whether updates were stored in the database | |||
| sessions = Session.objects.filter(meeting=meeting, group=mars) | |||
| sessions = Session.objects.filter(meeting=meeting, group=mars).order_by("id") # order to match edit() view | |||
There was a problem hiding this comment.
In case anyone looks back and notices this PR does more than remove the pin - this test happened to show instability while testing removal of the pin. We accepted taking the fix as part of this PR intentionally.
rjsparks
approved these changes
Jul 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin is not needed since inflect 6.0.5. As of inflect 6.1.0, pydantic 2.0 is supported.