Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't show replaced, expired or otherwise abandoned docs for AD #5162

Merged
merged 6 commits into from
Feb 21, 2023

Conversation

larseggert
Copy link
Collaborator

Fixes #5153 and #2889.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #5162 (4a73d15) into main (f9c2376) will decrease coverage by 0.01%.
The diff coverage is 89.02%.

@@            Coverage Diff             @@
##             main    #5162      +/-   ##
==========================================
- Coverage   88.54%   88.53%   -0.01%     
==========================================
  Files         295      295              
  Lines       40046    40058      +12     
==========================================
+ Hits        35458    35467       +9     
- Misses       4588     4591       +3     
Impacted Files Coverage Δ
ietf/doc/urls.py 100.00% <ø> (ø)
ietf/doc/views_doc.py 91.53% <ø> (+0.15%) ⬆️
ietf/meeting/views.py 90.85% <ø> (-0.01%) ⬇️
ietf/secr/sreq/forms.py 97.32% <77.77%> (-0.99%) ⬇️
ietf/api/views.py 89.44% <89.55%> (-0.03%) ⬇️
ietf/api/urls.py 100.00% <100.00%> (ø)
ietf/doc/views_search.py 89.46% <100.00%> (+0.22%) ⬆️
ietf/sync/discrepancies.py 100.00% <100.00%> (ø)
ietf/utils/text.py 85.97% <0.00%> (-1.22%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@larseggert
Copy link
Collaborator Author

@rjsparks better?

Copy link
Member

@rjsparks rjsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is what you want. I do think it would be better to unwrap the logic puzzle into something that requires less thinking when the next coder gets here. I've suggested an alternative.

ietf/doc/views_search.py Outdated Show resolved Hide resolved
ietf/doc/views_search.py Outdated Show resolved Hide resolved
@rjsparks rjsparks merged commit 90b6cf4 into ietf-tools:main Feb 21, 2023
@larseggert larseggert deleted the fix-5153 branch February 22, 2023 00:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How do I kill a chartering effort?
2 participants