Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only show irtf stream ballot and pubreq buttons to the IRTF chair #5036

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

rjsparks
Copy link
Member

fixes #5009

Tests haven't been added to verify non-IRTF chair IRSG members don't get buttons and can't access views. Those will come as part of the refactor of the views and tests in #5011

Copy link
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'd be inclined to refactor the check added to request_publication() to use a single, common, permission_denied() call, but no objection to it as it is.

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #5036 (b3c2056) into main (570bd14) will decrease coverage by 0.01%.
The diff coverage is 94.64%.

@@            Coverage Diff             @@
##             main    #5036      +/-   ##
==========================================
- Coverage   88.47%   88.46%   -0.01%     
==========================================
  Files         296      296              
  Lines       39818    39855      +37     
==========================================
+ Hits        35230    35259      +29     
- Misses       4588     4596       +8     
Impacted Files Coverage Δ
ietf/doc/views_draft.py 91.79% <50.00%> (-0.17%) ⬇️
ietf/meeting/views.py 90.69% <98.00%> (+0.12%) ⬆️
ietf/doc/views_doc.py 91.17% <100.00%> (ø)
ietf/meeting/templatetags/proceedings_filters.py 88.23% <0.00%> (-5.89%) ⬇️
ietf/meeting/models.py 85.91% <0.00%> (-0.59%) ⬇️
ietf/group/models.py 92.30% <0.00%> (-0.37%) ⬇️
ietf/doc/views_search.py 89.23% <0.00%> (ø)
ietf/iesg/agenda.py 92.06% <0.00%> (+0.06%) ⬆️
ietf/utils/text.py 86.58% <0.00%> (+0.60%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rjsparks rjsparks merged commit 5560c28 into ietf-tools:main Jan 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2023
@rjsparks rjsparks deleted the pubreqbuttons branch February 2, 2023 23:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rg chairs get the "Issue IRSG Ballot", "Begin IESG Conflict Review" and "Request publication" buttons
2 participants