Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework community views to operate on Person instead of User #5859

Closed
1 task done
jennifer-richards opened this issue Jun 21, 2023 · 1 comment
Closed
1 task done
Labels
accepted component: community/ enhancement New feature or request feat/user2person Refactoring objects that point into User that should have pointed into Peron medium

Comments

@jennifer-richards
Copy link
Member

Description

The views in ietf.community.views take a username parameter and use these to look up the relevant CommunityList, etc. This should be refactored to be a Person-centric interface, looking up the relevant Person based on their email address (à la the /person/ view) and then making use of the refactored CommunityList model that now links to a Person.

This applies to the feat/user2person branch at the moment.

Code of Conduct

@rjsparks rjsparks added the feat/user2person Refactoring objects that point into User that should have pointed into Peron label Jun 21, 2023
rjsparks added a commit that referenced this issue Jan 24, 2024
* refactor: change references from User to Person (#5821)

* refactor: Change CommunityList reference from User to Person

* refactor: Convert more user references to person

* refactor: Change augment_docs_and_user_with_user_info to person

* refactor: Change Nomination and Feedback references from User to Person

* refactor: Change a few test case function signatures to be more pythonic

* refactor: Harmonize how profile and photo views look up email_or_name

* refactor: Rework community views to operate on Person instead of User (#5859)

* test: Update tests to try all of the person's emails and aliases

* fix: Recode a test case to avoid an exception if there's Unicode in the URL

This only happens using the form-filling and submission feature of
WebTest, which is only used in this one test case, so just it rip out.

* test: Add duplicate-person tests

* fix: If there are multiple matching users, prefer the logged-in one.

* chore: We no longer use WebTest, so don't include it.

* fix: Address review comments

* fix: case-insensitive person name or email matching (#6096)

* chore: Renumber migrations

* fix: Update merged code so tests pass (#6887)

* fix: Use refactored method

* fix: Don't assume user has person

* fix: Use new view param name

* chore: Drop community lists w/o person; cleanup (#6896)

* fix: Don't assume user has person

* fix: user->person in update_community_list_index.py

* feat: Remove CommunityLists without Person

* refactor: Speed up nomcom migrations

---------

Co-authored-by: Paul Selkirk <[email protected]>
Co-authored-by: Jennifer Richards <[email protected]>
@jennifer-richards
Copy link
Member Author

Fixed by #6024

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted component: community/ enhancement New feature or request feat/user2person Refactoring objects that point into User that should have pointed into Peron medium
Projects
None yet
Development

No branches or pull requests

2 participants