Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change references from User to Person #5821

Merged
merged 6 commits into from
Jun 20, 2023

Conversation

pselkirk
Copy link
Collaborator

Fixes #2142

@pselkirk
Copy link
Collaborator Author

pselkirk commented Jun 14, 2023

This first commit converts CommunityList. It passes relevant unit testing, but it could use more scrutiny.

I do see an unrelated test failure in ietf.doc.tests.PdfizedTests.test_pdfized: OSError: [Errno 99] Cannot assign requested address. I don't see how it could be related, but I haven't gone back to test the main branch.

@jennifer-richards
Copy link
Member

jennifer-richards commented Jun 14, 2023

I do see an unrelated test failure in ietf.doc.tests.PdfizedTests.test_pdfized: OSError: [Errno 99] Cannot assign requested address. I don't see how it could be related, but I haven't gone back to test the main branch.

This was fixed in f3831de. If you update to current main (and either update your ietf/settings_local.py with the change or rebuild your containers) it should resolve that test failure.

ietf/community/models.py Outdated Show resolved Hide resolved
ietf/community/models.py Outdated Show resolved Hide resolved
ietf/community/models.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #5821 (8519a35) into feat/user2person (518aedb) will increase coverage by 0.09%.
The diff coverage is 98.14%.

@@                 Coverage Diff                  @@
##           feat/user2person    #5821      +/-   ##
====================================================
+ Coverage             88.65%   88.75%   +0.09%     
====================================================
  Files                   288      288              
  Lines                 39950    39960      +10     
====================================================
+ Hits                  35419    35467      +48     
+ Misses                 4531     4493      -38     
Impacted Files Coverage Δ
ietf/api/views.py 89.79% <ø> (ø)
ietf/secr/rolodex/views.py 70.00% <ø> (-0.50%) ⬇️
ietf/doc/utils.py 87.33% <88.88%> (+0.19%) ⬆️
ietf/nomcom/utils.py 91.40% <90.90%> (-0.03%) ⬇️
ietf/community/forms.py 96.59% <100.00%> (-0.04%) ⬇️
ietf/community/models.py 88.88% <100.00%> (-0.21%) ⬇️
ietf/community/utils.py 94.73% <100.00%> (ø)
ietf/community/views.py 97.60% <100.00%> (+0.01%) ⬆️
ietf/doc/utils_search.py 80.70% <100.00%> (+0.11%) ⬆️
ietf/doc/views_doc.py 91.62% <100.00%> (+<0.01%) ⬆️
... and 5 more

... and 7 files with indirect coverage changes

@pselkirk pselkirk marked this pull request as ready for review June 20, 2023 01:56
@rjsparks rjsparks changed the base branch from main to feat/user2person June 20, 2023 17:50
@rjsparks rjsparks merged commit 24cd6a7 into ietf-tools:feat/user2person Jun 20, 2023
@pselkirk pselkirk deleted the fix-2142 branch June 20, 2023 20:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change references to User
3 participants