Skip to content

Feedbacks resolved - #77

Merged
dev-rathore merged 1 commit into
devfrom
feedback-resolved-24jan
Jan 27, 2025
Merged

dev-rathore merged 1 commit into
devfrom
feedback-resolved-24jan

Conversation

@dev-rathore

@dev-rathore dev-rathore commented Jan 25, 2025 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

Release Notes

  • UI Updates

    • Updated icons for the "Explore" tab and drawer menu to use heart icons
    • Improved theme consistency for modal content background color
  • Styling

    • Dynamically set modal background color based on current theme
  • Chores

    • Updated shared-libs subproject commit

@dev-rathore dev-rathore self-assigned this Jan 25, 2025
@coderabbitai

coderabbitai Bot commented Jan 25, 2025 •

Copy link
Copy Markdown

Walkthrough

This pull request introduces visual updates to the application's navigation components, focusing on icon modifications across multiple files. The changes primarily involve replacing the house icon with heart icons in the tab and drawer layouts. The updates span the tab layout, drawer menu content, and collaboration details components, with a consistent theme of updating icon representations. Additionally, a style modification in the collaboration details stylesheet adjusts the modal content's background color to be theme-responsive.

Changes

File Change Summary
app/(main)/(drawer)/(tabs)/_layout.tsx Replaced faHouseUserSolid with faHeartSolid and added faHeart icon for conditional tab icon rendering
components/collaboration/collaboration-details/InvitationsTabContent.tsx Added Text component import from @/components/theme/Themed
components/drawer-layout/DrawerMenuContent.tsx Updated "Explore" menu item icons from house to heart icons
styles/collaboration-details/CollaborationDetails.styles.tsx Changed messageModalContent background color to use theme-based dynamic color
shared-libs Updated subproject commit reference

Suggested reviewers

  • Manan-Sharma-5

Possibly related PRs

Poem

🐰 Hop, hop, icons take flight,
Hearts replace houses, oh what delight!
From tabs to drawers, a visual dance,
Themed colors bloom with each glance,
Code rabbits rejoice in this design's might! 🎨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
components/drawer-layout/DrawerMenuContent.tsx (1)

Line range hint 33-33: Remove unused HomeIcon import.

The HomeIcon import is no longer used after switching to heart icons.

-import HomeIcon from "@/assets/icons/home.svg";
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0193d8c and 9a66762.

📒 Files selected for processing (5)
  • app/(main)/(drawer)/(tabs)/_layout.tsx (2 hunks)
  • components/collaboration/collaboration-details/InvitationsTabContent.tsx (1 hunks)
  • components/drawer-layout/DrawerMenuContent.tsx (2 hunks)
  • shared-libs (1 hunks)
  • styles/collaboration-details/CollaborationDetails.styles.tsx (0 hunks)
💤 Files with no reviewable changes (1)
  • styles/collaboration-details/CollaborationDetails.styles.tsx
✅ Files skipped from review due to trivial changes (2)
  • shared-libs
  • components/collaboration/collaboration-details/InvitationsTabContent.tsx
🔇 Additional comments (4)
app/(main)/(drawer)/(tabs)/_layout.tsx (2)

14-14: LGTM: Icon imports are properly organized.

The heart icons are correctly imported from their respective packages, maintaining consistency with other icon imports.

Also applies to: 19-19


53-59: LGTM: Tab icon implementation follows best practices.

The icon implementation:

  • Correctly uses conditional rendering based on focus state
  • Maintains consistent sizing with other tab icons
  • Follows the established pattern used by other tabs
components/drawer-layout/DrawerMenuContent.tsx (2)

19-19: LGTM: Icon imports are properly organized.

The heart icons are correctly imported from their respective packages, maintaining consistency with other icon imports.

Also applies to: 25-25


91-96: LGTM: Drawer icon implementation follows best practices.

The icon implementation:

  • Correctly uses conditional rendering based on focus state
  • Uses the DrawerIcon component consistently
  • Matches the pattern used by other menu items

@dev-rathore
dev-rathore merged commit ece2935 into dev Jan 27, 2025
dev-rathore added a commit that referenced this pull request Jan 27, 2025
* pushed new contract screens

* fixed member container

* Redesign application and invitation cards (#51)

* redesign application and invitation cards

* added keyboard view

* fixes

* added underline in file attachment

* ui-feedback

* added work

* minor changes

* Repurpose messaging screen (#53)

* repurpose messaging screen

* accept application changes

* added phases

* invitationId as influencerId

* fixed signup signin

* fix: bug on brand creation

* minor changes

* minor changes

* minor changes

* minor changes

* pushed a minor change

* fix: accept application (#56)

* fix: accept application

* fix: managerId

* ui fix

* Redirection fixes (#59)

* fix: initial redirections

* scheme change

* router navigate fix

* router navigate fix

* Redirection changes (#61)

* redirection changes

* redirection changes

* image component and other fixes

* No brands protected screen implementation (#64)

* added no brands protected screen and shimmer ui

* shimmer ui update

* added loading indicator

* brand protected screen bug fix

* shared-uis conflict

* shared-uis conflict

* fix: build

* pushed ui fixes

* social button change

* Bug fixes (#68)

* bug fixes

* bug fixes

* message screen fix

* pushed ui fix

* pushed icons

* Bug fixes (#69)

* bug fixes

* render html, location address, and rating section

* refactored code

* refactor

* refactor

* location address changes

* messages icons changes

* pushed new icons

* pushed brand modal fixes

* pushed changes

* Icons changes (#73)

* icons changes

* icons changes

* email verification

* changed icon

* pushed slight change to dev for a slight route change

* merge conflict

* refactor code (#75)

* feedbacks resolved (#77)

* pushed changes

* Feedbacks resolved (#79)

* feedbacks resolved

* max width refactor

* removed unused imports

* reusable component fix

---------

Co-authored-by: Manan Sharma <112090668+Manan-Sharma-5@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants