Skip to content

Icons changes - #73

Merged
dev-rathore merged 3 commits into
devfrom
icons-changes
Jan 17, 2025
Merged

dev-rathore merged 3 commits into
devfrom
icons-changes

Conversation

@dev-rathore

@dev-rathore dev-rathore commented Jan 16, 2025 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

Release Notes

  • UI Improvements

    • Updated icons across multiple components for enhanced visual clarity
    • Refined icon selection for collaboration creation screens, notifications, and contract views
  • Authentication

    • Improved sign-up process with email verification tracking
    • Added automatic navigation after successful account verification
  • Subproject Update

    • Updated shared UI components to latest version

These changes focus on improving user interface consistency and streamlining the authentication experience.

@dev-rathore dev-rathore self-assigned this Jan 16, 2025
@coderabbitai

coderabbitai Bot commented Jan 16, 2025 •

Copy link
Copy Markdown

Walkthrough

The pull request encompasses a series of icon and import modifications across various components in the project. Changes primarily involve updating Font Awesome icons in different screens and components, such as replacing faVideo with faHouseLaptop and faChain with faLink. Additionally, a significant update to the AuthContextProvider introduces a new email verification mechanism that recursively checks and handles user verification after sign-up. The modifications are mostly cosmetic and aim to improve the visual representation and user authentication flow.

Changes

File Change Summary
components/contracts/ActionContainer.tsx Replaced faNoteSticky with faCircleInfo icon
components/create-collaboration/screen-layout.tsx Replaced faClose with faXmark icon
components/create-collaboration/screen-one.tsx Updated promotion type icons: faVideo → faGift, faDollarSign → faHandHoldingDollar
components/create-collaboration/screen-three.tsx Changed external link icon from faChain to faLink
components/create-collaboration/screen-two.tsx Updated location type icons: faVideo → faHouseLaptop, faPhotoFilm → faMapLocationDot
components/notifications/notification-icon.tsx Removed FontAwesome import from @expo/vector-icons
contexts/auth-context.provider.tsx Added checkVerification method for email verification
shared-uis Updated subproject commit reference

Sequence Diagram

sequenceDiagram
    participant User
    participant AuthContext
    participant VerificationSystem
    
    User->>AuthContext: signUp()
    AuthContext->>VerificationSystem: Check Email Verification
    alt Email Not Verified
        VerificationSystem-->>AuthContext: Retry Verification
        AuthContext->>VerificationSystem: Recursive Check (every 2s)
    else Email Verified
        VerificationSystem-->>AuthContext: Verification Confirmed
        AuthContext->>User: Navigate to Onboarding
    end
Loading

Suggested Reviewers

  • Manan-Sharma-5

Poem

🐰 Icons dancing, a playful sight,
Rabbits hop through code so bright
Verification's new embrace,
Smooth authentication's grace
CodeRabbit's magic takes its flight! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bca7539 and 5cf0f92.

📒 Files selected for processing (8)
  • components/contracts/ActionContainer.tsx (3 hunks)
  • components/create-collaboration/screen-layout.tsx (2 hunks)
  • components/create-collaboration/screen-one.tsx (2 hunks)
  • components/create-collaboration/screen-three.tsx (2 hunks)
  • components/create-collaboration/screen-two.tsx (2 hunks)
  • components/notifications/notification-icon.tsx (0 hunks)
  • contexts/auth-context.provider.tsx (2 hunks)
  • shared-uis (1 hunks)
💤 Files with no reviewable changes (1)
  • components/notifications/notification-icon.tsx
✅ Files skipped from review due to trivial changes (4)
  • components/create-collaboration/screen-layout.tsx
  • components/create-collaboration/screen-two.tsx
  • shared-uis
  • components/contracts/ActionContainer.tsx
🔇 Additional comments (2)
components/create-collaboration/screen-one.tsx (1)

169-177: LGTM! Icon changes improve semantic meaning.

The new icons better represent their respective collaboration types:

  • faGift for barter collaboration suggests non-monetary exchange
  • faHandHoldingDollar for paid collaboration clearly indicates monetary transaction
components/create-collaboration/screen-three.tsx (1)

182-182: LGTM! Updated to modern icon.

The change from faChain to faLink is appropriate as it uses the current icon while maintaining the same semantic meaning.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dev-rathore
dev-rathore merged commit 654f917 into dev Jan 17, 2025
dev-rathore added a commit that referenced this pull request Jan 23, 2025
* pushed new contract screens

* fixed member container

* Redesign application and invitation cards (#51)

* redesign application and invitation cards

* added keyboard view

* fixes

* added underline in file attachment

* ui-feedback

* added work

* minor changes

* Repurpose messaging screen (#53)

* repurpose messaging screen

* accept application changes

* added phases

* invitationId as influencerId

* fixed signup signin

* fix: bug on brand creation

* minor changes

* minor changes

* minor changes

* minor changes

* pushed a minor change

* fix: accept application (#56)

* fix: accept application

* fix: managerId

* ui fix

* Redirection fixes (#59)

* fix: initial redirections

* scheme change

* router navigate fix

* router navigate fix

* Redirection changes (#61)

* redirection changes

* redirection changes

* image component and other fixes

* No brands protected screen implementation (#64)

* added no brands protected screen and shimmer ui

* shimmer ui update

* added loading indicator

* brand protected screen bug fix

* shared-uis conflict

* shared-uis conflict

* fix: build

* pushed ui fixes

* social button change

* Bug fixes (#68)

* bug fixes

* bug fixes

* message screen fix

* pushed ui fix

* pushed icons

* Bug fixes (#69)

* bug fixes

* render html, location address, and rating section

* refactored code

* refactor

* refactor

* location address changes

* messages icons changes

* pushed new icons

* pushed brand modal fixes

* pushed changes

* Icons changes (#73)

* icons changes

* icons changes

* email verification

* changed icon

* pushed slight change to dev for a slight route change

* merge conflict

* refactor code (#75)

---------

Co-authored-by: Manan Sharma <112090668+Manan-Sharma-5@users.noreply.github.com>
@coderabbitai coderabbitai Bot mentioned this pull request Jan 25, 2025
dev-rathore added a commit that referenced this pull request Jan 27, 2025
* pushed new contract screens

* fixed member container

* Redesign application and invitation cards (#51)

* redesign application and invitation cards

* added keyboard view

* fixes

* added underline in file attachment

* ui-feedback

* added work

* minor changes

* Repurpose messaging screen (#53)

* repurpose messaging screen

* accept application changes

* added phases

* invitationId as influencerId

* fixed signup signin

* fix: bug on brand creation

* minor changes

* minor changes

* minor changes

* minor changes

* pushed a minor change

* fix: accept application (#56)

* fix: accept application

* fix: managerId

* ui fix

* Redirection fixes (#59)

* fix: initial redirections

* scheme change

* router navigate fix

* router navigate fix

* Redirection changes (#61)

* redirection changes

* redirection changes

* image component and other fixes

* No brands protected screen implementation (#64)

* added no brands protected screen and shimmer ui

* shimmer ui update

* added loading indicator

* brand protected screen bug fix

* shared-uis conflict

* shared-uis conflict

* fix: build

* pushed ui fixes

* social button change

* Bug fixes (#68)

* bug fixes

* bug fixes

* message screen fix

* pushed ui fix

* pushed icons

* Bug fixes (#69)

* bug fixes

* render html, location address, and rating section

* refactored code

* refactor

* refactor

* location address changes

* messages icons changes

* pushed new icons

* pushed brand modal fixes

* pushed changes

* Icons changes (#73)

* icons changes

* icons changes

* email verification

* changed icon

* pushed slight change to dev for a slight route change

* merge conflict

* refactor code (#75)

* feedbacks resolved (#77)

* pushed changes

* Feedbacks resolved (#79)

* feedbacks resolved

* max width refactor

* removed unused imports

* reusable component fix

---------

Co-authored-by: Manan Sharma <112090668+Manan-Sharma-5@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants