Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows logging in on staging instances. Since for each redirect_uri/callback url must be registered with Google Cloud for security reasons, the callbacks for staging instances do not work. However, by default, our code sends the callback back to prod instead of the staging instance. This PR makes use of this by passing the correct host to redirect the callback to in the state parameter in the Google authentication URL and on callback to prod, prod will redirect callback requests that are meant for staging instances back to the staging instance.
The redirection couldn't be tested as is with prod without actually merging to master and testing on prod... so I tested it by changing the callback URL from the prod domain environment variable to http://localhost:5000/api/users/callback. Then I ran PeterPortal locally and tried logging in on the staging instance and it correctly sent the callback to localhost and my local server redirected it back to the staging instance, successfully signing me in on the staging instance. I think I'll leave that right now for the sake of testing during review and will change it back before I merge.
Steps to verify/test this change:
Final Checks:
(optional)