Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page where users reviews are displayed #270

Merged
merged 4 commits into from
Jun 9, 2023

Conversation

advayanand
Copy link
Collaborator

@advayanand advayanand commented Mar 3, 2023

Description

Frontend

  • Added a reviews tab on the sidebar (/reviews) where the currently logged in user's reviews are displayed.
  • Users can delete their reviews by clicking the delete button under the review they wish to delete
  • Reviews page is not displayed if the user is not logged in

Backend

  • Updated the DELETE /reviews endpoint to allow users to delete their own reviews

Screenshots

Screen.Recording.2023-03-05.at.4.33.25.PM.mov

Steps to verify/test this change:

Final Checks:

  • Verify successful deployment
  • Delete branch

(optional)

  • Write tests
  • Write documentation

@advayanand advayanand linked an issue Mar 3, 2023 that may be closed by this pull request
3 tasks
@advayanand advayanand changed the title Add profile page where users reviews are displayed Add page where users reviews are displayed Mar 6, 2023
Copy link
Member

@ethanwong16 ethanwong16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work @advayanand 🥳 !!

I left a couple of comments and questions, but they're pretty minor and I'll go ahead and just give you approval.

It would also be great if you could document information about working with Mongo / the reviews for future devs, as well as any information you might know about the Mongo schema.

site/src/component/SideBar/SideBar.tsx Outdated Show resolved Hide resolved
site/src/component/UserReviews/UserReviews.tsx Outdated Show resolved Hide resolved
api/src/controllers/reviews.ts Outdated Show resolved Hide resolved
api/src/controllers/reviews.ts Show resolved Hide resolved
@ethanwong16
Copy link
Member

Closes #193

@ethanwong16
Copy link
Member

Once #291 is merged into master and working, feel free to check real quick that this feature works and merge as well

@js0mmer
Copy link
Member

js0mmer commented Jun 1, 2023

Merged #291. You can go ahead and update the branch and test it out. Also don't forget to update any api calls you've added to start with /api.

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Deployed staging instance to https://staging-270.peterportal.org

@advayanand advayanand merged commit 35b0177 into master Jun 9, 2023
@advayanand advayanand deleted the advay/show-users-reviews branch October 13, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show Users Reviews
3 participants