Increase session cookie max age (#384)

* Increase session length to 30 days * fix: set session length on user cookie
icssc · Dec 10, 2023 · 4aeed3d · 4aeed3d
1 parent 360c131
commit 4aeed3d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/api/src/app.ts b/api/src/app.ts
@@ -28,6 +28,8 @@ import graphqlRouter from './controllers/graphql';
 import roadmapRouter from './controllers/roadmap';
 import reportsRouter from './controllers/reports';
 
+import { SESSION_LENGTH } from './config/constants';
+
 // instantiate app
 const app = express();
 
@@ -49,7 +51,7 @@ if (process.env.MONGO_URL) {
     secret: process.env.SESSION_SECRET,
     resave: false,
     saveUninitialized: false,
-    cookie: { maxAge: 1000 * 60 * 60 * 24 },
+    cookie: { maxAge: SESSION_LENGTH },
     store: store,
   }));
   app.use(passport.initialize());

diff --git a/api/src/config/constants.ts b/api/src/config/constants.ts
@@ -0,0 +1 @@
+export const SESSION_LENGTH = 30 * 86400 * 1000;
diff --git a/api/src/controllers/users.ts b/api/src/controllers/users.ts
@@ -4,6 +4,7 @@
 
 import express, { Request, Response } from 'express';
 import passport from 'passport';
+import { SESSION_LENGTH } from '../config/constants';
 
 let router = express.Router();
 
@@ -158,7 +159,9 @@ router.get('/auth/github/callback',
 function successLogin(req: Request, res: Response) {
   console.log('Logged in', req.user);
   // set the user cookie
-  res.cookie('user', req.user);
+  res.cookie('user', req.user, {
+    maxAge: SESSION_LENGTH
+  });
   // redirect browser to the page they came from
   let returnTo = req.session.returnTo ?? '/';
   delete req.session.returnTo;