Rebase1 #643
Open
Rebase1 #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the unnecessary type casting of values of the
journal logs based on supported types mentioned in LG2 documentation
[1].
Testing: Verified the debug traces to correct.
'''
For Instance:
Earlier -
error(”TYPE = {TYPE} “, “TYPE”, static_cast<unsigned>(PLDM_STATE_EFFECTER_PDR));
Journal trace -
May 27 08:16:51 p10bmc pldmd[931]: TYPE = 11
After Correction -
error(”TYPE = {TYPE}“, “TYPE”, PLDM_STATE_EFFECTER_PDR);
Journal trace -
May 27 08:16:51 p10bmc pldmd[931]: TYPE = Enum(11)
'''
[1]: https://github.com/openbmc/phosphor-logging/blob/master/docs/structured-logging.md#lg2
Change-Id: Ia649ecd4ecbb73c421f7844885f58a6835805719
Signed-off-by: Riya Dixit <[email protected]>
Currently bios attributes are added in three json configuration files based on the attribute type(integer, string, enum). Combining all the attributes in single bios attribute json file to organize the attributes based on the usage pattern. Tested: BMC powered on successfully Unit tests passed Change-Id: I42cc7c2394918e48d27dca2041f8ce00509c565a Signed-off-by: Archana Kakani <[email protected]>
Removing default string length from BIOS json configuration
files.
String BIOS attributes defined in BIOS configuration json file
contains "default_string_length". Providing default string length
manually is error prone. As String length can be calculated and
populated easily in the code, removing json support for
default_string_length.
Tested: Power on/off
Gtests passed.
Change-Id: I7604d8ccedd60a39ba07e1df67ff5712f31e7f6e
Signed-off-by: Archana Kakani <[email protected]>
Converting following bios attribute json keys to lower snake case
displayName --> display_name
helpText --> help_text
readOnly --> read_only
Tested:
Power on/off
Gtest passed
Change-Id: Iad88ed7bc381d66182c99e31e7d385f65750e0ed
Signed-off-by: Archana Kakani <[email protected]>
Abstract the custom method of `OEM-IBM` into the oem-ibm.hpp file to prevent the continuous increase of custom code and reduce multiple `OEM-IBM` entry points in pldmd. Tested: enabled oem-ibm and built pldm successfully. Signed-off-by: George Liu <[email protected]> Change-Id: Ieddb8d12281553e70bdb1c333bd29425c9d14fb0
PLDM receives topology data in IBM proprietary format from remote terminus. As part of this commit, we are parsing the topology and cable data and caching the information. Tested: Power ON/OFF successful Change-Id: I15a563aeecdd2b193fbc40b23dc225456b882be2 Signed-off-by: Archana Kakani <[email protected]>
This commit corrects various spelling mistakes throughout the repository. The corrections were made automatically using `codespell`[1] tool. [1]: https://github.com/codespell-project/codespell Change-Id: I539a0c5baa63be240fc1c76367c0af338dd89c7b Signed-off-by: Manojkiran Eda <[email protected]>
This commit adds support to eliminating duplication of datatypes which enhancing clarity and manageability throughout the pldm repository. This is rearrangement of declaration of data types so it can be used host-bmc and oem layer both the places. Change-Id: Ieb1232884b8e2128e8bf97dafd01e4ad5524ede0 Signed-off-by: Kamalkumar Patel <[email protected]>
Added requester::sendRecvPldmMsg awaiter type to be able to send and receive PLDM message by coroutine. Added TerminusManager to discover terminus from EID list updated by MCTPDiscovery class. The TerminusManager will initialize TID. Signed-off-by: Gilbert Chen <[email protected]> Signed-off-by: Thu Nguyen <[email protected]> Change-Id: Ifa5bdfff50648f1d7fba8710e160de662e8f9e06
Fixes the following error when building with gmock supplied by
subproject:
```
FAILED: common/test/pldm_utils_test.p/pldm_utils_test.cpp.o
ccache c++ -Icommon/test/pldm_utils_test.p -I../subprojects/googletest/googletest/include -I../subprojects/googletest/googletest -Isubprojects/googletest/__CMake_build -I../subprojects/googletest/__CMake_build -Isubprojects/googletest -I../subprojects/googletest -Isubprojects/phosphor-dbus-interfaces/gen -I../subprojects/phosphor-dbus-interfaces/gen -I../subprojects/sdbusplus/include -Isubprojects/phosphor-logging/lib/include -I../subprojects/phosphor-logging/lib/include -I. -I.. -I/usr/include -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Wpedantic -Werror -std=c++23 -O2 -g -Wno-psabi -DLIBPLDMRESPONDER -DOEM_IBM -include /home/andrew/src/openbmc.org/openbmc/pldm/build/config.h -DBOOST_ASIO_DISABLE_THREADS -DBOOST_ALL_NO_LIB -DBOOST_SYSTEM_NO_DEPRECATED -DBOOST_ERROR_CODE_HEADER_ONLY -DBOOST_COROUTINES_NO_DEPRECATION_WARNING -pthread -isystem../subprojects/nlohmann_json/single_include -isystem../subprojects/libpldm/include -isystemsubprojects/libpldm/include -isystem../subprojects/googletest/googletest -isystem../subprojects/googletest/googletest/include -MD -MQ common/test/pldm_utils_test.p/pldm_utils_test.cpp.o -MF common/test/pldm_utils_test.p/pldm_utils_test.cpp.o.d -o common/test/pldm_utils_test.p/pldm_utils_test.cpp.o -c ../common/test/pldm_utils_test.cpp
In file included from ../common/test/pldm_utils_test.cpp:2:
../common/test/mocked_utils.hpp:3:10: fatal error: gmock/gmock.h: No such file or directory
3 | #include <gmock/gmock.h>
| ^~~~~~~~~~~~~~~
compilation terminated.
```
Change-Id: I56cedd3df2d07f850fc0d13599ed52f99981e35b
Signed-off-by: Andrew Jeffery <[email protected]>
The sdbusplus headers provide shortened aliases for many types. Switch to using them to provide better code clarity and shorter lines. Possible replacements are for: * bus_t * exception_t * manager_t * match_t * message_t * object_t * slot_t Change-Id: I3aa6b1e86072f2af81e7792bc4a13a012c359187 Signed-off-by: Patrick Williams <[email protected]>
This commit aims at migrating the custom_dbus files from the host_bmc directory to the host-bmc/dbus directory. This makes the code cleaner since it abstracts all the dbus objects hosting code to the dbus folder Change-Id: Ia310e8a16f9489060ef228496d364c602a4fa6a8 Signed-off-by: Kamalkumar Patel <[email protected]>
libpldm is now an external dependency rather than an in-tree library. Adjust the includes accordingly. Change-Id: I97218ec9cf7ffb7afa98e78c01dc9d030271c3f4 Signed-off-by: Andrew Jeffery <[email protected]>
The non-deprecated paths for OEM header files use a directory hierarchy that reflects the OEM in question. The fix was generated using the following command with the coccinelle patch from [1]: ``` $ spatch \ --sp-file ../libpldm/origin/evolutions/current/oem-ibm-header-compat.cocci \ --in-place \ $(git ls-files | grep -E '\.[ch](pp)?') ``` [1]: https://gerrit.openbmc.org/c/openbmc/libpldm/+/72202 Change-Id: Iabea7a20e6e59b9671abb7b4f838215c50873594 Signed-off-by: Andrew Jeffery <[email protected]>
This commit introduces essential D-Bus infrastructure support for hosting the `Item.CPUCore` D-Bus object. Additionally, it includes getter and setter functions to enable get/set properties within the `CPUCore` interface, such as core count and microcode. Testing: Unit test passed Change-Id: I728522b34e96ee7d6609efb5746b40cf923812e8 Signed-off-by: Kamalkumar Patel <[email protected]>
This commit adds value_name json key to BIOS attribute that allows user to enable/disable the dynamic deallocation of memory based on predictive memory fail events. Tested: Verified the BIOS attribute with get bios attribute command from pldmtool. Change-Id: I913d2062c1d7af024a447f9eb4e0289fa7ebdf12 Signed-off-by: Riya Dixit <[email protected]>
There are a lot of warnings reported by markdownlint in the CI, this commit aims at fixing all of them. Tested : No more warnings reported by markdownlint in the CI. Change-Id: I92d24bc0efd230dd0974ff49853ef928caf1febd Signed-off-by: Manojkiran Eda <[email protected]>
This commit corrects various spelling mistakes throughout the repository. The corrections were made automatically using `codespell`[1] tool. [1]: https://github.com/codespell-project/codespell Change-Id: I16082f7e664541e98fa1cae2b2bcce59dd9cb250 Signed-off-by: Manojkiran Eda <[email protected]>
The BIOS attributes supported by OpenBMC systems are added in JSON files, adhering to the specifications outlined in the PLDM BIOS Specification [1]. Since a single BIOS attribute may have different values for different variants of systems, creating different json files for each of the system type supported. To enable this optional feature within PLDM, creating meson option system-specific-bios-json. System specific bios attributes support in PLDM is added in below commits [2], [3], [4] [1]: https://www.dmtf.org/sites/default/files/standards/documents/DSP0247_1.0.0.pdf [2]: https://github.com/openbmc/pldm/tree/963c0fdf1aef305f266e00b2321fc244f89d0fa7 [3]: https://github.com/openbmc/pldm/tree/62dd8ff2f106c0eb80e8c1e79adfa99e093d1cf6 [4]: https://github.com/openbmc/pldm/tree/46f352ed2426368185f3bd36fd6bf88f15fa5111 Change-Id: Ieffdca541d1ff8489911b02c178f85d3b1b84a5c Signed-off-by: Archana Kakani <[email protected]>
Adding support to host dbus PCIeSlot interface.
Based on the PDRs received from remote PLDM terminus,
PLDM hosts the dbus interface based on the entity type.
The Slot interface is defined at [1].
Tested:
Functional test passed.
[1]: https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/yaml/xyz/openbmc_project/Inventory/Item/PCIeSlot.interface.yaml
Change-Id: I98db6c31ddcb35e5c124d060c4ee0ab0f8819e72
Signed-off-by: Archana Kakani <[email protected]>
Adding support to host PCIeDevice dbus interface. Based on the PDRs received from remote PLDM terminus, PLDM hosts the dbus interface based on the entity type. The PCIe Device interface is defined at [1]. Tested: Functional test passed [1]: https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/yaml/xyz/openbmc_project/Inventory/Item/PCIeDevice.interface.yaml Change-Id: I69472efef33c3ad030ba4c831f07f60833b2c40b Signed-off-by: Archana Kakani <[email protected]>
Adding support to host Cable dbus interface. Based on the PDRs received from remote PLDM terminus, PLDM hosts the dbus interface based on the entity type. The Cable interface is defined at [1]. [1]: https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/yaml/xyz/openbmc_project/Inventory/Item/Cable.interface.yaml Change-Id: I23f02387c1d50ce8d9c5921760740760cea2cd47 Signed-off-by: Archana Kakani <[email protected]>
This commit adds support to find the system type by checking the JSON directory presence when entity manager sends the system names. Once system type is set then PLDM continues the further operations like pdr generation, system specific bios etc... Testing: Tested on real hardware Change-Id: I3b0a7725a72cd3a3c8fe0a4c6ff6b38510a2a2ea Signed-off-by: Kamalkumar Patel <[email protected]>
Fix PLDMD crash if endpoint device doesn't response. Change-Id: I13c0292bdb681567593fbc4a62685e6393f88a82 Signed-off-by: Jerry C Chen <[email protected]>
If oem-ibm is disabled, but system-specific-bios-json option is enabled pldmd fails to start since its timing out waiting to request the bus name. This fix also breaks the dependency between the above two meson options. Tested: - Was able to successfully start pldm service and see that the bus name was claimed with oem-ibm disabled & system-specific-bios-json enabled. Change-Id: Ie78521017ea20b7503b4425bf4c2f605c884ef1d Signed-off-by: Manojkiran Eda <[email protected]>
Bypassing the remote endpoint status check before responding to GetPDR requests prevents potential issues due to the variable behavior of remote PLDM termini. If a remote terminus sends a GetPDR request before responding to the GetPLDMVersion command, a race condition may occur. Therefore, it is safer to skip the remote endpoint alive check. Change-Id: I9b2a186fee7f8d3a382b1573d872596728c9f7d4 Signed-off-by: Manojkiran Eda <[email protected]>
The PDR exchange is always triggered from the remote end point. Hence BMC should never ask for GetPDR by itself. Change-Id: Ibc90cdd5118ad1bc7665bc681b0aa89994a5e400 Signed-off-by: Manojkiran Eda <[email protected]>
This commit logs PEL when BMC fails to collect PDR from remote endpoint. GetPDR returns no response because of BMC PDR exchange failure after three tries get exhausted and timeout occurs. Tested: Verified that the new PEL is reported when the pdr response pointer is null Change-Id: I862693a7e0fe2405af625010f2862d25af1f11e2 Signed-off-by: Riya Dixit <[email protected]>
IBM has a feature called LampTest and what it does is this:
- BMC would set the state of LEDs to [ON] on all the BMC accessible
LEDs.
- For LEDs that are not accessible by BMC, a message is sent to the
Host, so that the Host can exercise all the LEDs on the connected
drawers and anything else that the BMC does not have access to.
This commit adds support to send message to Host when BMC has to tell
the Host to exercise LEDs accessible by host.
When Host sees the effector is set, it goes ahead and turns [ON] all
the LEDs for a specified time and automatically restores the states
at timer expiration. BMC does not have to tell the Host to stop the
test and it is part of Host's lamp test requirement.
TESTED: By setting the asserted property of the LED groups object
busctl set-property xyz.openbmc_project.LED.GroupManager
/xyz/openbmc_project/led/groups/lamp_test
xyz.openbmc_project.Led.Group Asserted b true
And verifying that the setEffecterStates call was made to the
remote state effecter to turn on all LEDs
Signed-off-by: George Liu <[email protected]>
Change-Id: I990dce28d3017f20c73ff9029fced0e7ac84868f
This commit introduces support for counting the number of CPU cores during BMC power-on and populates this information to a DBus property named coreCount. Upon BMC power-on, the remote terminus detects the number of CPU cores and send this data and PLDM will updates the coreCount property accordingly. Tested: tested on simulator for hosting DBus property Change-Id: I37adbe399414fcff3f089fb819349ca4bb537edd Signed-off-by: Kamalkumar Patel <[email protected]>
During a rename, set the next boot side to Perm (same as current) so that in case of a failed update, PHYP knows to boot from the Perm side. The next boot side would be set to Temp on a successful update (via the Priority callback function). Update the next boot side attribute (fw_boot_side) whenever the next boot side value is set or changed so that in error scenarios, PHYP knows which side to boot from. Setting fw_boot_side attribute automatically calls the function to set the next boot side because the attribute can be also be set externally by PHYP, therefore check the requested next boot side already has the highest priority, in which case there's no need to set the Priority. Also checking the current priority allows to catch if the alternate version may not exist because of a code update that failed or is in progress. Once an image is uploaded, set the non running version to the uploaded image since the current non running image will be deleted during the update. Tested: Verified the fw_boot_side attribute matched the information in the persisted bootSide file. The Priority value was only set when needed (the requested next boot side was different than the current next boot side). During a rename, both current and next are set to Perm. Signed-off-by: Sagar Srinivas <[email protected]>
This commits add code to minimise sending redundant bios attribute change events to host. Defect:SW546927 Signed-off-by: Sagar Srinivas <[email protected]>
This commit adds code to reset the image activation signal match every time after sending the end update sensor event PHYP. This is done in order for pldm to receive the image activation after every successful inband code update with or without system reboot. Test: Performed inband code update on IBMi and AIX OS. Signed-off-by: Sagar Srinivas <[email protected]>
…bmc#259) ImageActivation match which is reset even before we receive the Image Active signal is received. Which is why we are failing to send the End update sensor event to PHYP. This needs to be reset only after the end update success/failure event to PHYP after receiving the Active signal on the activation property. Defect:SW551662 Signed-off-by: Sagar Srinivas <[email protected]>
This commit sets the pvm_boot_type attribute to ReIPL when we are in the MPIPL path. DEFECT:SW552266 Signed-off-by: Sagar Srinivas <[email protected]>
Wait on the Software Updater before getting the Association endpoints, during the code update as there maybe delays in BMC software updater. Defect:SW554311 Signed-off-by: Sagar Srinivas <[email protected]>
As per current design of PLDM, newly forked process assembles
lid files and create a tar ball of code update image.
But any error occurred during assembling process was not
communicated to host by the forked process.
Now on Phosphor-bmc-code-mgmt repo will take care of assembling
the lid files.
PLDM calls the DBus method AssembleLids hosted by bmc-code-mgmt
after receiving end update from host.
And keeps listening to the Version path and Activation interface.
Based on Activation value(Active/Invalid) takes necessary action.
Tested:
Inband Code update (success/failure) tested successfully.
Signed-off-by: Archana Kakani <[email protected]>
Whenever we receive a heartbeat message from Host(HB or PHYP), check for the TID of the HOST to identify if TID is from PHYP and we failed to receive the heartbeat pings after the elapsed timer interval, log the informational PEL. 1.Tested by creating a manual guard which will push the system to a reconfig loop. 2.Flashed a new single image and powered on host 3.Intensionally stopped surveillance pings from PHYP using PHYP macro DEFECT:SW550554 Signed-off-by: Sagar Srinivas <[email protected]>
This commit is to disable the timer when we fail to receive the surveillance pings from PHYP. DEFECT:SW551173 Signed-off-by: Sagar Srinivas <[email protected]>
The version id is now a random number in order to support the upload of the same version: [1] https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-bmc-code-mgmt/+/49972 Therefore the version id would be different when uploaded and after a reboot. A unique identifier has been added to the Path property, this specifies the location on flash of the version, on emmc is the partition "a" or "b". Therefore, use that property instead of the version id to know if the bmc has booted from the same version or not. Tested: - After code update: Feb 11 19:42:04 rain118bmc pldmd[1545]: BMC have booted with the new image runningPath=a Feb 11 19:42:04 rain118bmc pldmd[1545]: Previous Image was: b root@p10bmc:~# cat /var/lib/pldm/bootSide Temp Temp a - After reboot on the same image: Feb 11 19:49:56 rain118bmc pldmd[601]: BMC have booted with the previous image runningPath=a Change-Id: I8b9713a7992525336169f3f639b4ef9ea77392d6 Signed-off-by: Adriana Kobylak <[email protected]>
This commit adds support for building Platform Dump Records (PDRs) related to DIMM and PROC entities. It handles DBus method calls for the respective dump types associated with each entity type. Additionally, it monitors dump progress status and triggers a request to set the host effecter. Test- Used pldmtool platform command for setNumericEffecter. Signed-off-by: Riya Dixit <[email protected]>
This commit adds a minor fix to isOemStateEffecter missed out in SBE Dump implement rebase due to which pldm was getting hung as code control was getting stuck in the while loop of pdrRecord check due to the missing else condition in the loop. Tested: Did persistent patch testing with setNumericEffecter cmd, did poweron of the persistent patch, flashed a complete openbmc image and did poweron till PHYP runtime. Also did boot side switch and poweron the driver to boot till PHYP runtime. Signed-off-by: Riya Dixit <[email protected]>
This supports the following password prompts for PFW (Platform Firmware) provided graphical SMS (System Management Services (SMS) menu In system configurations that include a graphics adapter assigned to a partition, PFW can display the SMS menus on the console allowing users to interact with PFW using a keybaord. This menu requires as they can be used to change partition configurations (e.g. Boot option, I/O device info etc.) Supported password prompt functions: 1. The ability to prompt for a username/password and provide authentication 2. The ability to change a password when the current password is expired Tested: Tested normal power on, power off and reset Change-Id: Ie42c5306e6447f65064bb8cb9480a3cde0e4ed4e Signed-off-by: Jayashankar Padath <[email protected]>
This commit enhances the displayName and helpText of hb_predictive_mem_guard and hb_predictive_mem_guard_current bios enum attributes. Tested: Did poweron and verified the change with redfish BIOS registry and also verified with dbus BIOS config manager. Signed-off-by: Riya Dixit <[email protected]>
This commit adds a fix to update container id by passing range of HB record handles to pldm_find_container_id api so as to search container id from BMC pdr and not HB pdr. Tested: Tested: Verified numeric effecter pdrs with entity association pdrs and state effecter pdrs to have same container id for a particular entity as populated in entity association BMC pdrs after normalization post PDR exchange [1]. [1]: https://gist.github.com/riyadixitagra/1a06a9ba32944193066a2d24efd66385 Signed-off-by: Riya Dixit <[email protected]>
This commit adds the dbus timeout while setting the changed firmware UAK value. Tested: Verified that UAK update is getting reflected in the corresponding UTIL D8 VPD keyword and the redfish Signed-off-by: Jayashankar Padath <[email protected]>
Added missed code and traces from 1060 in code update path. The problem faced during existing code update code is the delay in receiving the system type. PLDM was setting the fw_boot_side and fw_boot_side_current before building the bios table. So those values where not getting set. To fix the issue saving the pending bios attributes before setting biostable and resetting it after biostable update. With the Fix pldm is booting from Temp side after codeupdate. Signed-off-by: Archana Kakani <[email protected]>
This commit handles the CoD license json parsing exception by correctly catching it and returns the error to the caller. Also made the change to avoid the removal of license json file whenever shared by the host. Tested: Done the sanity testing to verify that json file was kept without removal. Signed-off-by: Jayashankar Padath <[email protected]>
This commit introduces new oem sensor PDRs of state set id - PLDM_OEM_IBM_SBE_DUMP_UPDATE_STATE(32777) whose state will be set for ocmb dump progress status. This change implements the new sensor based dump design only for ocmb sbe dumps whereas the sbe PROC dump design remains unchanged. As part of this change PLDM will be updating the sensor state with dump progress state. The remote terminus will be using polling mechanism on getStateSensorReadings command for dump status update. Tested: 1. Used pldmtool to set numeric effecter for triggering dump. 2. Tested using sbe error injection( unrecoverable by HRESET ) during IPL [1] and during runtime[1]. Also verified the sensor readings post dump completion. Additionally verified SBE PROC dump [2]. [1]: https://gist.github.com/riyadixitagra/1b02a56477d98bfda158e2112aba0476 [2]: https://gist.github.com/riyadixitagra/3f61ec85722acf2f1983a9f2d8f5e4f0 Signed-off-by: Riya Dixit <[email protected]>
This commit corrects the error log name according to the latest PEL message registry values. Tested: Restart of the pldm daemon does not cause any new error logs. Signed-off-by: Jayashankar Padath <[email protected]>
Updated the Power supply attribute name from hb_power_PS*_functional to hb_power_PS*_present to match the upstream. The upstream for this change is https://gerrit.openbmc.org/c/openbmc/pldm/+/61015 Signed-off-by: Archana Kakani <[email protected]>
This commit fixes the issue where the BMC dump or the checkstop dump generated in a non-hmc managed system is not getting offloaded to the Operating System. Fixes: EWM 643345 Tested By: Verified that BMC dump and checkstop dump are getting offloaded successfully from BMC. Signed-off-by: Jayashankar Padath <[email protected]>
This commit adds support to implement the topology interface and also host it under PLDM and also supports the set and get property under the topology interface. When PCIeTopologyRefresh property is set to true, we send the setEffecterCall to host to set the effecter state 1 and 2. When SaveTopologyRefresh property is set to true we send the setEffecterCall to host to set the effecter state to 3 and then sets it back to false. Testing in progress Change-Id: Ic53f6fd33bbc4a84136b3f70517ee5cb4d8488a3 Signed-off-by: Pavithra Barithaya <[email protected]>
This commit fixes the issue of calculating the processor core count incorrectly. Fixes: STG Defect 658536 Tested By: Tested the changes in a Blue ridge system and verified that, the processor core count is coming up correctly under each of the processors. Signed-off-by: Jayashankar Padath <[email protected]>
Change LanesInUse to type size_t from int64_t. This change is made as per upstream changes at [1] [1]: https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/53650 Signed-off-by: Pavithra Barithaya <[email protected]>
This commit introduces two new string bios attributes to capture system code level version with which last CEC full IPL was performed and another attribute to capture version level in case of MPIPL (after concurrent code update) scenario. Both the attributes will be updated by remote terminus during every IPL. Tested: Verified with a BMC poweron Signed-off-by: Riya Dixit <[email protected]>
Removing the check for IBM cable card because this will be verified in VPD and there is no need to have an additional check inside PLDM. This commit also includes the check for presence property before PDRs are added for adapters and ports. PDRs should not be added for empty slots. Tested by : performing CM on IBM cable cards and industry standard adapters Signed-off-by: Varsha Kaverappa <[email protected]>
The commit does few things - parses the primary links and secondary links - updates the DBus accordingly Tested the topology data on the GUI. Change-Id: If40641383cd089b57c4043bc67d6f670a5f29996 Signed-off-by: Pavithra Barithaya <[email protected]>
oem: ibm: PCIe Topology support
oem: ibm: fileTable: Add hostboot hash lids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.