Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oem-ibm: Introducing sensor design for SBE ocmb dump #622

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

riyadixitagra
Copy link
Contributor

This commit introduces new oem sensor PDRs of state set id - PLDM_OEM_IBM_SBE_DUMP_UPDATE_STATE(32777) whose state will be set for ocmb dump progress status. This change implements the new sensor based dump design only for ocmb sbe dumps whereas the sbe PROC dump design remains unchanged. As part of this change PLDM will be updating the sensor state with dump progress state. The remote terminus will be using polling mechanism on getStateSensorReadings command for dump status update.

Tested:

  1. Used pldmtool to set numeric effecter for triggering dump.
  2. Tested using sbe error injection( unrecoverable by HRESET ) during IPL 1 and during runtime1. Also verified the sensor readings post dump completion. Additionally verified SBE PROC dump 2.

This commit introduces new oem sensor PDRs of state set id -
PLDM_OEM_IBM_SBE_DUMP_UPDATE_STATE(32777) whose state will be set for
ocmb dump progress status. This change implements the new sensor based
dump design only for ocmb sbe dumps whereas the sbe PROC dump design
remains unchanged. As part of this change PLDM will be updating the
sensor state with dump progress state. The remote terminus will be using
polling mechanism on getStateSensorReadings command for dump status
update.

Tested:
1. Used pldmtool to set numeric effecter for triggering dump.
2. Tested using sbe error injection( unrecoverable by HRESET ) during
IPL [1] and during runtime[1]. Also verified the sensor readings post
dump completion. Additionally verified SBE PROC dump [2].

[1]: https://gist.github.com/riyadixitagra/1b02a56477d98bfda158e2112aba0476
[2]: https://gist.github.com/riyadixitagra/3f61ec85722acf2f1983a9f2d8f5e4f0

Signed-off-by: Riya Dixit <[email protected]>
@rfrandse rfrandse merged commit 12a2e33 into ibm-openbmc:1110 Oct 14, 2024
1 check passed
ArchanaKakani pushed a commit to ArchanaKakani/pldm that referenced this pull request Dec 10, 2024
This commit introduces new oem sensor PDRs of state set id -
PLDM_OEM_IBM_SBE_DUMP_UPDATE_STATE(32777) whose state will be set for
ocmb dump progress status. This change implements the new sensor based
dump design only for ocmb sbe dumps whereas the sbe PROC dump design
remains unchanged. As part of this change PLDM will be updating the
sensor state with dump progress state. The remote terminus will be using
polling mechanism on getStateSensorReadings command for dump status
update.

Tested:
1. Used pldmtool to set numeric effecter for triggering dump.
2. Tested using sbe error injection( unrecoverable by HRESET ) during
IPL [1] and during runtime[1]. Also verified the sensor readings post
dump completion. Additionally verified SBE PROC dump [2].

[1]: https://gist.github.com/riyadixitagra/1b02a56477d98bfda158e2112aba0476
[2]: https://gist.github.com/riyadixitagra/3f61ec85722acf2f1983a9f2d8f5e4f0

Signed-off-by: Riya Dixit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants