Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8726: Added support for IsBookmarked criterion #123

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

ciastektk
Copy link
Contributor

@ciastektk ciastektk commented Aug 22, 2024

🎫 Issue IBX-8726

Related PRs:

Description:

For QA:

Documentation:

@ciastektk ciastektk force-pushed the ibx-8726-added-support-for-is-bookmarked-criterion branch 3 times, most recently from d62647f to a6b2600 Compare August 23, 2024 07:24
@ciastektk ciastektk requested a review from a team August 23, 2024 07:38
@konradoboza konradoboza requested a review from a team August 23, 2024 09:21
{
$request = $this->createHttpRequest(
'POST',
'/api/ibexa/v2/bookmark/43'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: relying on volatile database ID. However we'd need to rewrite this into new test-rest package tests, which is not possible for rest itself yet. Just keeping this as a note to myself here ;)

@ciastektk ciastektk force-pushed the ibx-8726-added-support-for-is-bookmarked-criterion branch from 21ead60 to 7d2d07b Compare September 4, 2024 13:39
Copy link

sonarcloud bot commented Sep 4, 2024

@alongosz alongosz merged commit 7a8dbe8 into 4.6 Sep 4, 2024
12 checks passed
@alongosz alongosz deleted the ibx-8726-added-support-for-is-bookmarked-criterion branch September 4, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants