Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8726: IsBookmarked search criterion added #2545

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Conversation

julitafalcondusza
Copy link
Contributor

@julitafalcondusza julitafalcondusza commented Nov 18, 2024

Question Answer
JIRA Ticket (ibexa/core#417)
Versions 4.6+

IsBookmarked search criterion added

Previews:

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Code samples are working

Copy link
Contributor

@ciastektk ciastektk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REST API examples are missing: ibexa/rest#123

Copy link
Contributor

@adriendupuis adriendupuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would precise "current user" earlier.

I'm not sure about the code_sample as it doesn't work as-is. Maybe it should be wrapped in command or something.

Copy link
Contributor

@adriendupuis adriendupuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestions are optional. It's already good.

Copy link

code_samples/ change report

Before (on target branch)After (in current PR)

code_samples/search/location/isbookmarked_criterion.php


code_samples/search/location/isbookmarked_criterion.php

docs/search/criteria_reference/isbookmarked_criterion.md@21:``` php
docs/search/criteria_reference/isbookmarked_criterion.md@22:[[= include_file('code_samples/search/location/isbookmarked_criterion.php', 2) =]]
docs/search/criteria_reference/isbookmarked_criterion.md@23:```

001⫶use Ibexa\Contracts\Core\Repository\Values\Content\LocationQuery;
002⫶use Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion\Location\IsBookmarked;
003⫶
004⫶$query = new LocationQuery();
005⫶$query->filter = new IsBookmarked();

Download colorized diff

@julitafalcondusza julitafalcondusza merged commit 23fbf48 into master Nov 25, 2024
5 of 6 checks passed
@julitafalcondusza julitafalcondusza deleted the IBX-8726 branch November 25, 2024 09:24
julitafalcondusza added a commit that referenced this pull request Nov 25, 2024
* IsBookmarked criterion added

* code moved to code_samples

* PHP CS Fixes

* REST API examples added

* Fixes after review

---------

Co-authored-by: julitafalcondusza <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants