Skip to content

IBX-10066: Change lint config to 2.0 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

IBX-10066: Change lint config to 2.0 #67

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ea1985
IBX-10066: Change lint config to 2.0
GrabowskiM May 26, 2025
441cc85
used explicit extensions
GrabowskiM May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .eslintrc.json
View file
Open in desktop

This file was deleted.

10 changes: 8 additions & 2 deletions .github/workflows/frontend-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,16 @@ name: Frontend build

on:
push:
paths:
- "**.[cm]?[jt]sx?"
- "**.scss"
branches:
- main
- '[0-9]+.[0-9]+'
pull_request: ~
pull_request:
paths:
- "**.[cm]?[jt]sx?"
Copy link

Copilot AI May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The glob pattern is missing a wildcard before the filename; it should be **/*.[cm]?[jt]sx? to match JS/TS(X) files in any directory.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The glob pattern under pull_request is missing a wildcard before the filename; use **/*.[cm]?[jt]sx? for consistency.

Suggested change
- "**.[cm]?[jt]sx?"
- "**/*.[cm]?[jt]sx?"

Copilot uses AI. Check for mistakes.
- "**.scss"
Copy link

Copilot AI May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The glob pattern is missing a wildcard before the filename; it should be **/*.scss to correctly match SCSS files in subdirectories.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The glob pattern under pull_request is missing a wildcard before the filename; it should be **/*.scss.

Copilot uses AI. Check for mistakes.

jobs:
frontend-test:
Expand All @@ -17,6 +23,6 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'
- run: yarn install
- run: yarn test
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ yarn-error.log
package-lock.json
.DS_Store
/composer.lock
tsconfig.json
5 changes: 5 additions & 0 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import getIbexaConfig from '@ibexa/eslint-config/eslint';

export default [
...getIbexaConfig(),
];
7 changes: 7 additions & 0 deletions ibexa.tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"extends": "@ibexa/ts-config",
"include": [
"src/bundle/**/*.ts",
"src/bundle/**/*.tsx"
]
}
14 changes: 8 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,20 @@
"description": "Ibexa Matrix Fieldtype",
"repository": "https://github.com/ezsystems/ezplatform-matrix-fieldtype.git",
"private": true,
"prettier": "eslint-config-ibexa/prettier",
"prettier": "@ibexa/eslint-config/prettier",
"dependencies": {},
"devDependencies": {
"eslint-config-ibexa": "https://github.com/ibexa/eslint-config-ibexa.git#~v1.2.0",
"@ibexa/ts-config": "https://github.com/ibexa/ts-config-ibexa#~v1.0.0",
"@types/react": "^18.3.11",
"@types/react-dom": "^18.3.1"
"@ibexa/eslint-config": "https://github.com/ibexa/eslint-config-ibexa.git#~v2.0.0",
"@ibexa/ts-config": "https://github.com/ibexa/ts-config-ibexa#~v1.1.0",
"@types/react": "^19.1.2",
"@types/react-dom": "^19.1.2"
},
"scripts": {
"test": "yarn prettier-test && yarn eslint-test",
"fix": "yarn prettier-test --write && yarn eslint-test --fix",
"ts-test": "tsc --noEmit",
"eslint-test": "eslint \"./src/bundle/Resources/**/*.{js,ts}\"",
"prettier-test": "yarn prettier \"./src/bundle/Resources/**/*.{js,ts,scss}\" --check"
"prettier-test": "yarn prettier \"./src/bundle/Resources/**/*.{js,ts,scss}\" --check",
"postinstall": "yarn ibexa-generate-tsconfig --use-root-project-tsconfig"
}
}
4 changes: 0 additions & 4 deletions tsconfig.eslint.json
View file
Open in desktop

This file was deleted.

Loading