IBX-10066: Change lint config to 2.0 #67
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the lint configuration and refines the frontend CI workflow to trigger only on relevant file changes, while also bumping the Node version.
- Introduces a new
eslint.config.mjsthat loads the Ibexa ESLint config. - Limits CI runs on push and pull requests to JS/TS(X) and SCSS files.
- Upgrades the CI Node version from 18 to 20.
Reviewed Changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| eslint.config.mjs | Adds default export that spreads the Ibexa ESLint config |
| .github/workflows/frontend-ci.yaml | Narrows workflow triggers based on file globs and updates Node version |
Files not reviewed (4)
- .eslintrc.json: Language not supported
- ibexa.tsconfig.json: Language not supported
- package.json: Language not supported
- tsconfig.eslint.json: Language not supported
.github/workflows/frontend-ci.yaml
Outdated
| - "**.[cm]?[jt]sx?" | ||
| - "**.scss" | ||
| branches: | ||
| - main | ||
| - '[0-9]+.[0-9]+' | ||
| pull_request: ~ | ||
| pull_request: | ||
| paths: | ||
| - "**.[cm]?[jt]sx?" |
There was a problem hiding this comment.
The glob pattern is missing a wildcard before the filename; it should be **/*.[cm]?[jt]sx? to match JS/TS(X) files in any directory.
| - "**.scss" | ||
| branches: | ||
| - main | ||
| - '[0-9]+.[0-9]+' | ||
| pull_request: ~ | ||
| pull_request: | ||
| paths: | ||
| - "**.[cm]?[jt]sx?" | ||
| - "**.scss" |
There was a problem hiding this comment.
The glob pattern is missing a wildcard before the filename; it should be **/*.scss to correctly match SCSS files in subdirectories.
.github/workflows/frontend-ci.yaml
Outdated
| pull_request: ~ | ||
| pull_request: | ||
| paths: | ||
| - "**.[cm]?[jt]sx?" |
There was a problem hiding this comment.
The glob pattern under pull_request is missing a wildcard before the filename; use **/*.[cm]?[jt]sx? for consistency.
| - "**.[cm]?[jt]sx?" | |
| - "**/*.[cm]?[jt]sx?" |
| - "**.scss" | ||
| branches: | ||
| - main | ||
| - '[0-9]+.[0-9]+' | ||
| pull_request: ~ | ||
| pull_request: | ||
| paths: | ||
| - "**.[cm]?[jt]sx?" | ||
| - "**.scss" |
There was a problem hiding this comment.
The glob pattern under pull_request is missing a wildcard before the filename; it should be **/*.scss.
|
3 participants
Description:
For QA:
Documentation: