IBX-10246: Made FieldDefinitionCreateStruct not translatable by default
#608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ezrobot
requested review from
Steveb-p,
ViniTou,
adamwojs,
alongosz,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
adamwojs
approved these changes
Jul 2, 2025
konradoboza
approved these changes
Jul 2, 2025
alongosz
approved these changes
Jul 2, 2025
tbialcz
approved these changes
Jul 2, 2025
|
QA Approved ✔️ |
adamwojs
deleted the
ibx-10246-not-translatable-FieldDefinitionCreateStruct
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As translatable field definition is not always fitting for all field types, and not translatable is fitting to all of them, I believe we should make it non translatable by default.
The issue is caused by setting default prop values for
FieldDefinitionCreateStruct: e6b1259#diff-3415ff00e96cde62bb78a1a6c2a14b192470da7064474b0dc035ef5368f074d5For QA:
Documentation: