IBX-10246: Made FieldDefinitionCreateStruct not translatable by default (#608)

Author: barw4

src/contracts/Repository/Values/ContentType/FieldDefinitionCreateStruct.php

@@ -59,7 +59,7 @@ class FieldDefinitionCreateStruct extends ValueObject
     /**
      * Indicates if the field is translatable.
      */
-    public bool $isTranslatable = true;
+    public bool $isTranslatable = false;
 
     /**
      * Indicates if the field is required.

tests/integration/Core/Repository/BaseTestCase.php

@@ -857,6 +857,7 @@ protected function createSimpleContentType(
                 $fieldDefinitionIdentifier,
                 $fieldTypeIdentifier
             );
+            $fieldDefinitionCreateStruct->isTranslatable = true;
             $contentTypeCreateStruct->addFieldDefinition($fieldDefinitionCreateStruct);
         }
         $contentTypeService->publishContentTypeDraft(

tests/integration/Core/Repository/ContentServiceTest.php

@@ -6674,6 +6674,7 @@ public function testCopyTranslationsFromInvalidPublishedContentToDraft()
         $contentTypeCreateStruct->names = ['eng-US' => 'Test content type for Copy Translations'];
         $fieldDefinition = $contentTypeService->newFieldDefinitionCreateStruct('name', 'ibexa_string');
         $fieldDefinition->position = 1;
+        $fieldDefinition->isTranslatable = true;
         $contentTypeCreateStruct->addFieldDefinition($fieldDefinition);
         $contentTypeService->publishContentTypeDraft(
             $contentTypeService->createContentType(
@@ -6718,6 +6719,7 @@ public function testCopyTranslationsFromInvalidPublishedContentToDraft()
         $fieldDefinition = $contentTypeService->newFieldDefinitionCreateStruct('req_field', 'ibexa_string');
         $fieldDefinition->position = 2;
         $fieldDefinition->isRequired = true;
+        $fieldDefinition->isTranslatable = true;
         $contentTypeService->addFieldDefinition($contentTypeDraft, $fieldDefinition);
         $contentTypeService->publishContentTypeDraft($contentTypeDraft);
 

tests/integration/Core/Repository/ContentTypeServiceTest.php

@@ -752,7 +752,7 @@ public function testNewFieldDefinitionCreateStructValues($createStruct)
                 'descriptions' => [],
                 'fieldGroup' => null,
                 'position' => null,
-                'isTranslatable' => true,
+                'isTranslatable' => false,
                 'isRequired' => false,
                 'isInfoCollector' => false,
                 'validatorConfiguration' => null,

tests/integration/Core/Repository/SearchService/SortClause/ContentTranslatedNameTest.php

@@ -195,6 +195,7 @@ private function createContentForContentTranslatedNameTesting(iterable $values):
         $fieldCreate->names = ['eng-GB' => 'value'];
         $fieldCreate->fieldGroup = 'main';
         $fieldCreate->position = 1;
+        $fieldCreate->isTranslatable = true;
 
         $contentTypeCreateStruct->addFieldDefinition($fieldCreate);