IBX-8399: Moved RepositoryConfigurationProvider to Repository layer #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
force-pushed
the
ibx-8399-move-repository-configuration-provider
branch
from
d421bca to
b94810a
Compare
Steveb-p
approved these changes
Jun 13, 2024
src/lib/Base/Container/ApiLoader/RepositoryConfigurationProvider.php
Outdated
Show resolved
Hide resolved
tests/bundle/Core/ApiLoader/BaseRepositoryConfigurationProviderTestCase.php
Show resolved
Hide resolved
konradoboza
approved these changes
Jun 14, 2024
webhdx
approved these changes
Jun 14, 2024
Steveb-p
approved these changes
Jun 15, 2024
Co-Authored-By: Paweł Niedzielski <[email protected]>
Co-Authored-By: Paweł Niedzielski <[email protected]>
Co-Authored-By: Paweł Niedzielski <[email protected]> Co-Authored-By: Konrad Oboza <[email protected]>
alongosz
force-pushed
the
ibx-8399-move-repository-configuration-provider
branch
from
16ae74a to
9130e95
Compare
Steveb-p
approved these changes
Jun 17, 2024
|
|
Note: regression tests for now are enough. There are no extra errors there compared to 5.0.x-dev baseline. |
barw4
pushed a commit
that referenced
this pull request
Oct 17, 2024
…383) For more details see https://issues.ibexa.co/browse/IBX-8399 and #383 Key changes: * Changed Core Bundle ApiLoader Exception to be Repository Exceptions * Extracted an interface from RepositoryConfigurationProvider * Refactored StorageConnectionFactory to rely on ServiceProviderInterface * Added missing readonly keyword in relevant places * Deprecated RepositoryConfigurationProvider located in Core Bundle namespace * [Tests] Aligned tests with the changes * [PHPStan] Aligned baseline with the changes * [PHPStan] Updated baseline after PHPStan release --------- Co-Authored-By: Paweł Niedzielski <[email protected]> Co-Authored-By: Konrad Oboza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
TL:DR;
Effectively moved
RepositoryConfigurationProviderfrom Bundle to Repository layer (for now actually deprecated the old class, but aiming to back-port deprecation to 4.6 and remove it in 5.0 as a follow-up).Background
We need to refactor DI configuration defining
RepositoryFactory(see related PR) so we can fix long outstanding ambiguity issues listed in the JIRA ticket. For now it will help with Symfony 5 Rectors refactoring. The changes done to./src/bundle/Core/ApiLoader/RepositoryFactory.phpare related to that refactoring (RepositoryConfigurationProviderinjection instead of$this->container->get()call) and probably can be applied in a simpler manner to resolve the target issue IBX-8138, however I feel like it's the highest time to do that cleanup - it's a low hanging fruit.But before we can do that, we need to move
RepositoryConfigurationProviderfrom the Bundle to the Repository layer as it's the most inner layer. I've done that in this PR and while at it I've introducedRepositoryConfigurationProviderInterfacecontracts.I've deprecated Core Bundle
RepositoryConfigurationProviderin favor of the Core Repository layer one (\Ibexa\Core\Base\Container\ApiLoader\RepositoryConfigurationProvider). Ideally I'd like to back-port that deprecation to 4.6, but as a follow-up due to time constraints.Additionally I've made
Ibexa\Bundle\Core\ApiLoader\Exception\*Exceptions final and implementing RepositoryInvalidArgumentExceptioninstead of the core PHP one.I've also cleaned up some minor parts of code touched around repository configuration provider injection refactoring.
Changelog:
For QA:
Regressions done via ibexa/commerce#872 should be enough.
Documentation: