Skip to content

Conversation

@alongosz
Copy link
Member

@alongosz alongosz commented Jun 12, 2024

🎫 Issue Related to IBX-8138

Related PRs:

Description:

Recommended to do prior the actual Symfony 5x Rector refactoring.
More details TBD - maybe will be split into 2 PRs.

List of changes:

  • Changed Core Bundle ApiLoader Exception to be Repository Exceptions
  • Extracted an interface from RepositoryConfigurationProvider
  • Fixed strict type of CleanupVersionsCommand::$connection property
  • [Tests] Aligned tests with RepositoryConfigurationProvider changes
  • [PHPStan] Aligned baseline with the changes
  • Dropped support for dynamic Core Repository class in RepositoryFactory
  • Made RepositoryFactory not Container-aware
  • Deprecated Core Bundle RepositoryFactory in favor of Repository's one
  • [PHPStan] Aligned baseline with the changes
  • Combined Bundle and core RepositoryFactory into one
  • [Tests] Added needed RepositoryFactory configuration to test setup

For QA:

Regression tests should be enough.

@alongosz alongosz force-pushed the ibx-8138-fix-repository-factory-di branch from 3f15b92 to 0df71e0 Compare June 13, 2024 11:28
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alongosz
Copy link
Member Author

@alongosz alongosz closed this Jun 13, 2024
@alongosz alongosz deleted the ibx-8138-fix-repository-factory-di branch June 13, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants