Merged branch '4.6' (PHPStan) #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed strict types of `ContentCreateData::$locationStructs` * Fixed array access in `UserUpdateMapper::mapToFormData` * Fixed strict types of `UserCreateData::getParentGroups`
…:$fieldTypeIdentifierMap`
alongosz
force-pushed
the
merge-up-phpstan
branch
from
fffc637 to
8f18be9
Compare
alongosz
force-pushed
the
merge-up-phpstan
branch
from
8f18be9 to
a786da7
Compare
This was referenced May 28, 2025
ezrobot
requested review from
adamwojs and
mikadamczyk
and removed request for
a team
ezrobot
requested review from
Steveb-p,
ViniTou,
barw4,
ciastektk,
konradoboza,
tbialcz and
wiewiurdp
alongosz
force-pushed
the
merge-up-phpstan
branch
from
ca21014 to
a786da7
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
❗ This is a merge up, to be merged in a fast-forward way
Related PRs:
Description:
This is a merge up of #90. I've resolved issues that appeared on main, related to Symfony 7 and strict types updates.
One of the most notable changes is declaration of generic types for
DataTransformerInterfaceimplementations. Not all of them popped up on PHPStan (due to the baseline from 4.6) but for the consistency's sake, I've decided to fix them all.TODO