IBX-9727: Aligned codebase with content-forms changes #1566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezrobot
requested review from
Steveb-p,
ViniTou,
adamwojs,
barw4,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
2 tasks
alongosz
force-pushed
the
align-with-content-forms-91
branch
from
640d94f to
0f9da78
Compare
|
adamwojs
approved these changes
May 29, 2025
GrabowskiM
pushed a commit
that referenced
this pull request
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
Related PRs:
Description:
ibexa/content-forms#91 fixes several issues found by PHPStan after Symfony 7 upgrade. It also adds some return strict types. Aligning here AdminUI codebase with those changes.
Note: should
\Ibexa\AdminUi\Validator\Constraints\ValidatorConfigurationValidator::validateaccept strictFieldDefinitionDataas$valuetype instead? That would change the behavior, so didn't touch it, but maybe it's a valid change? Also reported by PHPStan in the baseline.Alternatively, I could roll back changes causing failure here. It wasn't quite visible when working on content-forms, found only by Behat at the end.
For QA:
Regression should be enough.