Skip to content

IBX-8140: Enabled authenticator manager-based security #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2024
Merged

IBX-8140: Enabled authenticator manager-based security #1264

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5aadcc
IBX-8140: Enabled authenticator manager-based security
konradoboza May 14, 2024
c2b9db3
fixed double abstract controller definition
konradoboza May 17, 2024
854b37e
cr remark
konradoboza May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/bundle/Resources/config/services/controllers.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,11 @@ services:
tags:
- controller.service_arguments

Ibexa\Bundle\AdminUi\Controller\ContentViewController: ~
Ibexa\Bundle\AdminUi\Controller\ContentViewController:
parent: Ibexa\Contracts\AdminUi\Controller\Controller
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really immediately see how setting this as parent definition helps. Especially since this definition lies in a completely different file it seems.

Have you considered using _instanceof to prevent forgetting that this parent has to be added to each controller of this type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I haven't. Til this point we have followed adding parent controller to all of the admin-ui-related ones. I only aimed to fix the ones that slipped between cracks and which I tracked down while working on enabling new security layer.

I would say that if this approach needs revisiting we should work on that separately as it's a bit out of scope of security-related changes.

Unless you had something else in mind.


Ibexa\Bundle\AdminUi\Controller\DashboardController: ~
Ibexa\Bundle\AdminUi\Controller\DashboardController:
parent: Ibexa\Contracts\AdminUi\Controller\Controller

Ibexa\Bundle\AdminUi\Controller\LanguageController:
parent: Ibexa\Contracts\AdminUi\Controller\Controller
Expand Down Expand Up @@ -226,8 +228,6 @@ services:
arguments:
$translationHelper: '@Ibexa\Core\Helper\TranslationHelper'

Ibexa\Contracts\AdminUi\Controller\Controller: ~

Ibexa\Bundle\AdminUi\Controller\FieldDefinitionController:
parent: Ibexa\Rest\Server\Controller
tags: ['controller.service_arguments']
Expand Down