-
Notifications
You must be signed in to change notification settings - Fork 17
IBX-8140: Enabled authenticator manager-based security #1264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-8140: Enabled authenticator manager-based security #1264
Conversation
cc93c9b to
24932c8
Compare
6d2f408 to
c2f406c
Compare
bfb4f1e to
c2b9db3
Compare
|
|
|
||
| Ibexa\Bundle\AdminUi\Controller\ContentViewController: ~ | ||
| Ibexa\Bundle\AdminUi\Controller\ContentViewController: | ||
| parent: Ibexa\Contracts\AdminUi\Controller\Controller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really immediately see how setting this as parent definition helps. Especially since this definition lies in a completely different file it seems.
Have you considered using _instanceof to prevent forgetting that this parent has to be added to each controller of this type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I haven't. Til this point we have followed adding parent controller to all of the admin-ui-related ones. I only aimed to fix the ones that slipped between cracks and which I tracked down while working on enabling new security layer.
I would say that if this approach needs revisiting we should work on that separately as it's a bit out of scope of security-related changes.
Unless you had something else in mind.




The idea is to engage Symfony mechanisms to check permissions. Otherwise, we end-up in the BO-user-protected templates which cannot perform any operations on
nulluser which is anonymous in the new Symfony security approach.Removal of the
Ibexa\Contracts\AdminUi\Controller\Controllerdefinition is done due to duplication, ref: https://github.com/ibexa/admin-ui/blob/main/src/bundle/Resources/config/services.yaml#L49.Related PRs:
Description:
For QA:
Documentation: