Skip to content

Tile subdivision #2521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions packages/Main/src/Layer/TiledGeometryLayer.js
Original file line number Diff line number Diff line change
Expand Up @@ -430,18 +430,13 @@
// TODO: pendingSubdivision mechanism is fragile, get rid of it
node.pendingSubdivision = true;

const command = {
/* mandatory */
view: context.view,
requester: node,
layer: this,
priority: 10000,
/* specific params */
extentsSource: extents,
redraw: false,
};

return context.scheduler.execute(command).then((children) => {
const promises = [];

for (const extent of extents) {
promises.push(this.convert(node, extent));
}

Check warning on line 438 in packages/Main/src/Layer/TiledGeometryLayer.js

View workflow job for this annotation

GitHub Actions / Build bundle, check Linter and generate documentation

Trailing spaces not allowed

Check warning on line 438 in packages/Main/src/Layer/TiledGeometryLayer.js

View workflow job for this annotation

GitHub Actions / Build bundle, check Linter and generate documentation

Trailing spaces not allowed

Check warning on line 438 in packages/Main/src/Layer/TiledGeometryLayer.js

View workflow job for this annotation

GitHub Actions / Functional tests

Trailing spaces not allowed
return Promise.all(promises).then((children) => {
for (const child of children) {
node.add(child);
child.updateMatrixWorld(true);
Expand Down
Loading