Tile subdivision #2521
Open
Tile subdivision #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jailln
approved these changes
Mar 14, 2025
clementcolin
force-pushed
the
tile_subdivision
branch
from
ae3b61b to
7d21a95
Compare
jailln
requested changes
Mar 14, 2025
| const promises = []; | ||
|
|
||
| for (const extent of extents) { | ||
| promises.push(this.convert(node, extent)); |
There was a problem hiding this comment.
I think we can go further and remove the promises chain of this.convert since they are not created synchronously. I'll give it a try
There was a problem hiding this comment.
I'll do it in another PR so we can merge this one :)
jailln
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subdivide tile is an operation that should not be in queue as is it can be blocked by incoming textures of other tile.
It can still be improve by deleting promises (therefore, pending subdivision may be deleted too)