Skip to content

Change version bounds to fix nixpkgs build#15

Merged
i-am-tom merged 1 commit intoi-am-tom:masterfrom
markus1189:version-bounds
Dec 22, 2020
Merged

Change version bounds to fix nixpkgs build#15
i-am-tom merged 1 commit intoi-am-tom:masterfrom
markus1189:version-bounds

Conversation

@markus1189
Copy link
Contributor

On the latest nixpkgs version, holmes fails to build, because it does not allow relude-0.7.*.* and base-4.14.1.0.

I bumped the bounds and checked locally that it builds + tests are green

@i-am-tom
Copy link
Owner

Lovely! Thanks very much :)

@i-am-tom i-am-tom merged commit ecbb6da into i-am-tom:master Dec 22, 2020
@i-am-tom
Copy link
Owner

@markus1189 you'll have to help me, I'm pretty ignorant here; do I need to do a new hackage release, or is this all you need?

@markus1189
Copy link
Contributor Author

@i-am-tom I would need a new release :) Was just coming here to say that, somehow I did not see your question 😅

@markus1189 markus1189 deleted the version-bounds branch December 24, 2020 09:40
@markus1189
Copy link
Contributor Author

markus1189 commented Dec 30, 2020

Friendly post christmas ping :) A new release would be great 😄

@i-am-tom
Copy link
Owner

i-am-tom commented Jan 4, 2021

Hello! Awesome, I'll do that now :D

@i-am-tom
Copy link
Owner

i-am-tom commented Jan 4, 2021

@markus1189 New version (0.3.2.0) should be uploaded now - hopefully everything works 🤞 Thanks for the nudge! I'll leave this open just in case I've messed something up 😄

@markus1189
Copy link
Contributor Author

Awesome, thanks!

markus1189 added a commit to markus1189/nixpkgs that referenced this pull request Jan 5, 2021
Thanks to i-am-tom/holmes#15 `holmes` now
builds successfully 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants