Skip to content

haskellPackages.holmes: unbreak#108459

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
markus1189:unbreak-holmes
Jan 6, 2021
Merged

haskellPackages.holmes: unbreak#108459
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
markus1189:unbreak-holmes

Conversation

@markus1189
Copy link
Contributor

Thanks to i-am-tom/holmes#15 holmes now builds successfully 🎉

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Thanks to i-am-tom/holmes#15 `holmes` now
builds successfully 🎉
Copy link
Member

@sternenseemann sternenseemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds on x86_64-linux.

@cdepillabout
Copy link
Member

Thanks again!

@cdepillabout cdepillabout merged commit 8f5c69c into NixOS:haskell-updates Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants