Remove workaround when setting popover attribute #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1801 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 68 68
Lines 1220 1220
Branches 465 465
=========================================
Hits 1220 1220 ☔ View full report in Codecov by Sentry. |
acelaya
commented
Nov 26, 2024
| @@ -147,7 +147,7 @@ export default function PopoverPage() { | |||
| <code>boolean</code> | |||
| </Library.InfoItem> | |||
| <Library.InfoItem label="default"> | |||
| <code>false</code> | |||
| <code>true</code> | |||
There was a problem hiding this comment.
Not related with this PR, but I forgot to update the default value here, as it was changed in a different PR than the one providing the documentation.
robertknight
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a workaround we had to prevent
popover={false}to result in apopoverattribute being added to the DOM element.That was fixed in preactjs/preact#4393, so setting
falsenow skips the attribute entirely.