Remove workaround when setting popover attribute

hypothesis · Nov 26, 2024 · 82734c2 · 82734c2
1 parent 8fef71d
commit 82734c2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/src/components/feedback/Popover.tsx b/src/components/feedback/Popover.tsx
@@ -248,10 +248,7 @@ export default function Popover({
         classes,
       )}
       ref={popoverRef}
-      // nb. Use `undefined` rather than `false` because Preact doesn't
-      // handle boolean values correctly for this attribute (it will set
-      // `popover="false"` instead of removing the attribute).
-      popover={asNativePopover ? 'auto' : undefined}
+      popover={asNativePopover && 'auto'}
       data-testid="popover"
       data-component="Popover"
     >

diff --git a/src/pattern-library/components/patterns/feedback/PopoverPage.tsx b/src/pattern-library/components/patterns/feedback/PopoverPage.tsx
@@ -147,7 +147,7 @@ export default function PopoverPage() {
                 <code>boolean</code>
               </Library.InfoItem>
               <Library.InfoItem label="default">
-                <code>false</code>
+                <code>true</code>
               </Library.InfoItem>
             </Library.Info>
           </Library.Example>