Skip to content

fix: clicking on checkbox does not select the option #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 14, 2021
Merged

fix: clicking on checkbox does not select the option #769

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
aba406e
fix: clicking on checkbox does not select the option
Apr 13, 2021
28555ac
fix: linterning code
Apr 13, 2021
0828aea
fix: changing function name
Apr 13, 2021
3e15ec7
Merge branch 'main' of github.com:hypertrace/hypertrace-ui into Check…
Apr 13, 2021
652907b
fix: adding UT
Apr 14, 2021
73dd8bf
fix: fixing UT
Apr 14, 2021
f04cd03
fix: fixing ut
Apr 14, 2021
effaa25
Merge branch 'main' of github.com:hypertrace/hypertrace-ui into Check…
Apr 14, 2021
e8f6634
fix: adding details
Apr 14, 2021
1b6054b
Merge branch 'main' of github.com:hypertrace/hypertrace-ui into Check…
Apr 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion projects/components/src/multi-select/multi-select.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,11 @@ import { MultiSelectJustify } from './multi-select-justify';
(click)="this.onSelectionChange(item)"
class="multi-select-option"
>
<ht-checkbox class="checkbox" [checked]="this.isSelectedItem(item)"></ht-checkbox>
<ht-checkbox
class="checkbox"
(click)="blockCheckboxPropagation($event)"
[checked]="this.isSelectedItem(item)"
></ht-checkbox>
<ht-icon
class="icon"
*ngIf="item.icon"
Expand Down Expand Up @@ -210,6 +214,10 @@ export class MultiSelectComponent<V> implements AfterContentInit, OnChanges {
return this.selected !== undefined && this.selected.filter(value => value === item.value).length > 0;
}

public blockCheckboxPropagation(event: Event): void {
event.preventDefault();
}

private setSelection(selected: V[]): void {
this.selected = selected;
this.setTriggerLabel();
Expand Down