Skip to content

Conversation

@palbizu
Copy link
Contributor

@palbizu palbizu commented Apr 13, 2021

Description

Prevent the default action in the checkbox located in the multi-select component to prevent the checkbox element from being cleared.

Testing

Visual Testing

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from a team as a code owner April 13, 2021 22:04
@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #769 (1b6054b) into main (dcb23ca) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #769   +/-   ##
=======================================
  Coverage   85.38%   85.38%           
=======================================
  Files         789      789           
  Lines       16143    16145    +2     
  Branches     2060     2060           
=======================================
+ Hits        13783    13785    +2     
  Misses       2329     2329           
  Partials       31       31           
Impacted Files Coverage Δ
...ponents/src/multi-select/multi-select.component.ts 98.48% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcb23ca...1b6054b. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@palbizu palbizu requested a review from aaron-steinfeld April 14, 2021 16:04
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@palbizu palbizu merged commit 8a9881a into main Apr 14, 2021
@palbizu palbizu deleted the CheckboxClick branch April 14, 2021 16:44
@github-actions
Copy link

Unit Test Results

    4 files  ±0  248 suites  ±0   14m 36s ⏱️ ±0s
889 tests +1  889 ✔️ +1  0 💤 ±0  0 ❌ ±0 
895 runs  +1  895 ✔️ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 8a9881a. ± Comparison against base commit dcb23ca.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants